Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ceph] Add Integration Package with Cluster Status data stream #5216

Merged
merged 2 commits into from
Feb 15, 2023
Merged

[Ceph] Add Integration Package with Cluster Status data stream #5216

merged 2 commits into from
Feb 15, 2023

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Feb 8, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Added 1 data stream (Cluster status metrics).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/ceph directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

@elasticmachine
Copy link

elasticmachine commented Feb 8, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-08T17:13:07.965+0000

  • Duration: 18 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kush-elastic kush-elastic added enhancement New feature or request Integration:ceph Ceph Team:Service-Integrations Label for the Service Integrations team labels Feb 8, 2023
@kush-elastic
Copy link
Collaborator

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 100.0% (57/57) 💚 5.66
Lines 93.858% (489/521) 👍 1.345
Conditionals 100.0% (0/0) 💚

@harnish-elastic harnish-elastic marked this pull request as ready for review February 9, 2023 04:48
@harnish-elastic harnish-elastic requested a review from a team as a code owner February 9, 2023 04:48
@harnish-elastic harnish-elastic mentioned this pull request Feb 10, 2023
Merged
4 tasks
agithomas
agithomas approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit f1f018c into elastic:main Feb 15, 2023
@elasticmachine
Copy link

Package ceph - 0.7.0 containing this change is available at https://epr.elastic.co/search?package=ceph

bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023
@harnish-elastic @bhapas
[Ceph] Add Integration Package with Cluster Status data stream (elast…
1d2bd76 
…ic#5216)

* add cluster status data stream

* update changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Integration:ceph Ceph Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harnish-elastic @elasticmachine @kush-elastic @agithomas