Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integrations][Cisco Meraki] - Removed experimental release tags from data streams #8175

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Bug

Proposed commit message

Removed experimental release tags from data streams. The integration was made GA with 8.4 but the tags remained, which was a bug.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG added integration Label used for meta issues tracking each integration Team:Security-External Integrations bugfix Pull request that fixes a bug issue labels Oct 12, 2023
@ShourieG ShourieG requested a review from P1llus October 12, 2023 10:05
@ShourieG ShourieG self-assigned this Oct 12, 2023
@ShourieG ShourieG requested a review from a team as a code owner October 12, 2023 10:05
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Oct 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-12T10:06:50.572+0000

  • Duration: 19 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (66/66) 💚 4.762
Lines 98.161% (1174/1196) 👍 21.029
Conditionals 100.0% (0/0) 💚

@ShourieG ShourieG merged commit d063080 into elastic:main Oct 12, 2023
4 checks passed
@ShourieG ShourieG deleted the bugfix/cisco_meraki_ga branch October 12, 2023 10:43
@elasticmachine
Copy link

Package cisco_meraki - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cisco_meraki Cisco Meraki integration Label used for meta issues tracking each integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants