Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Make Cisco ISE syslog priority field optional #9533

Merged
merged 3 commits into from
Apr 9, 2024
Merged

[Enhancement] Make Cisco ISE syslog priority field optional #9533

merged 3 commits into from
Apr 9, 2024

Conversation

dwhyrock
Copy link
Contributor

@dwhyrock dwhyrock commented Apr 5, 2024 •
edited
Loading

Implements request from #9368

Proposed commit message

Makes the log.syslog.priority field optional when parsing Cisco ISE logs in order to not error on logs that do not include this value.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@dwhyrock dwhyrock added the enhancement New feature or request label Apr 5, 2024
@dwhyrock dwhyrock requested a review from a team as a code owner April 5, 2024 21:19
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

taylor-swanson
taylor-swanson approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkoutsovasilis pkoutsovasilis mentioned this pull request Apr 8, 2024
Merged
4 tasks
@dwhyrock dwhyrock added Integration:cisco_ise Cisco ISE Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Apr 9, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@dwhyrock dwhyrock merged commit ddcb044 into elastic:main Apr 9, 2024
5 checks passed
@dwhyrock dwhyrock deleted the 9368-cisco-ise-syslog-no-priority branch April 9, 2024 13:44
@elasticmachine
Copy link

Package cisco_ise - 1.22.1 containing this change is available at https://epr.elastic.co/search?package=cisco_ise

@dwhyrock dwhyrock mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:cisco_ise Cisco ISE Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwhyrock @elasticmachine @pkoutsovasilis @taylor-swanson