Skip to content
This repository was archived by the owner on Jan 31, 2024. It is now read-only.

Set up bind mounted kibana repository #51

Merged
merged 1 commit into from
May 10, 2019
Merged

Set up bind mounted kibana repository #51

merged 1 commit into from
May 10, 2019

Conversation

Conky5
Copy link
Contributor

@Conky5 Conky5 commented May 10, 2019

Run yarn kbn bootstrap and yarn add git-hash-package against the
kibana repository when binding mounting one from disk. Also tweak the
build script to fail fast if files are missing, exit on errors, and
remove unnecessary shell && \'s.

Run `yarn kbn bootstrap` and `yarn add git-hash-package` against the
kibana repository when binding mounting one from disk. Also tweak the
build script to fail fast if files are missing, exit on errors, and
remove unnecessary shell `&& \`'s.
@Conky5 Conky5 requested review from mgreau, mw-ding and Poytr1 May 10, 2019 16:45
@Conky5
Copy link
Contributor Author

Conky5 commented May 10, 2019

I tested this manually on a internal-ci worker using release-manager and the build was successful (more detail https://github.com/elastic/release-manager/pull/611#issuecomment-490621130), artifacts are located here for anyone who wants to check them out:

aws s3 cp --recursive s3://snapshots-dev.elastic.co/8.0.0-24c3d9f2/ .

Copy link
Contributor

@Poytr1 Poytr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@Conky5 Conky5 merged commit 4a661e3 into elastic:master May 10, 2019
@Conky5 Conky5 deleted the set-up-prequisites-when-using-kibana-mount branch May 10, 2019 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants