This repository was archived by the owner on Jan 31, 2024. It is now read-only.
Fix user id and .m2 permission #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By introducing a new CI user for running the build in #52, we encountered two problems. First one is that the CI user id we are creating in the Docker image could be the same as the node user (1000), because it's a common value. This commit fixes it by updating the node user id. The second problem is a permission issue when mouting the .m2 folder into the container, which prevents Maven to work. This commit fixes it by using a Docker volume for the .m2 cache. It means that the cache can be shared between all builds while the `m2-vol` volume is not deleted.
mw-ding
approved these changes
May 22, 2019
mgreau
pushed a commit
that referenced
this pull request
May 22, 2019
By introducing a new CI user for running the build in #52, we encountered two problems. First one is that the CI user id we are creating in the Docker image could be the same as the node user (1000), because it's a common value. This commit fixes it by updating the node user id. The second problem is a permission issue when mouting the .m2 folder into the container, which prevents Maven to work. This commit fixes it by using a Docker volume for the .m2 cache. It means that the cache can be shared between all builds while the `m2-vol` volume is not deleted.
mgreau
pushed a commit
that referenced
this pull request
May 22, 2019
By introducing a new CI user for running the build in #52, we encountered two problems. First one is that the CI user id we are creating in the Docker image could be the same as the node user (1000), because it's a common value. This commit fixes it by updating the node user id. The second problem is a permission issue when mouting the .m2 folder into the container, which prevents Maven to work. This commit fixes it by using a Docker volume for the .m2 cache. It means that the cache can be shared between all builds while the `m2-vol` volume is not deleted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By introducing a new CI user for running the build in #52, we
encountered two problems (as explained in #52 (comment))
First one is that the CI user id we are creating in the Docker image
could be the same as the node user (1000), because it's a common value.
This commit fixes it by updating the node user id.
The second problem is a permission issue when mounting the .m2
folder into the container, which prevents Maven to work.
This commit fixes it by using a Docker volume for the .m2 cache.
It means that the cache can be shared between all builds while the
m2-volvolume is not deleted.
I have tested it in the release manager VM