Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom role delete modal to account for multiple role assignments #184116

Closed
legrego opened this issue May 23, 2024 · 1 comment · Fixed by #184529
Closed

Update custom role delete modal to account for multiple role assignments #184116

legrego opened this issue May 23, 2024 · 1 comment · Fixed by #184529
Assignees
Labels
enhancement New value added to drive a business result Feature:Users/Roles/API Keys Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@legrego
Copy link
Member

legrego commented May 23, 2024

We present users with a model when deleting custom roles within our serverless offering. Here are mockups of what it looks like today:
image

Now that we support multiple role assignments, we should update the language to indicate that the user may lose access, depending on their other role assignments.

diff --git a/x-pack/plugins/security/public/management/roles/roles_grid/confirm_delete/confirm_delete.tsx b/x-pack/plugins/security/public/management/roles/roles_grid/confirm_delete/confirm_delete.tsx
index bc434f61dab..f67889244ed 100644
--- a/x-pack/plugins/security/public/management/roles/roles_grid/confirm_delete/confirm_delete.tsx
+++ b/x-pack/plugins/security/public/management/roles/roles_grid/confirm_delete/confirm_delete.tsx
@@ -83,7 +83,7 @@ export class ConfirmDelete extends Component<Props, State> {
                   <p>
                     <FormattedMessage
                       id="xpack.security.management.roles.confirmDelete.serverless.removingRolesDescription"
-                      defaultMessage="Users with the following roles assigned will lose access to the project:"
+                      defaultMessage="Users with the following roles assigned may lose access to the project if they are not assigned any other roles:"
                     />
                   </p>
                 )}
@@ -99,7 +99,7 @@ export class ConfirmDelete extends Component<Props, State> {
                   <p>
                     <FormattedMessage
                       id="xpack.security.management.roles.confirmDelete.serverless.removingSingleRoleDescription"
-                      defaultMessage="Users with the {roleName} role assigned will lose access to the project."
+                      defaultMessage="Users with the {roleName} role assigned may lose access to the project if they are not assigned any other roles."
                       values={{ roleName: rolesToDelete[0] }}
                     />
                   </p>
@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result Feature:Users/Roles/API Keys labels May 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@SiddharthMantri SiddharthMantri self-assigned this May 30, 2024
SiddharthMantri added a commit that referenced this issue May 31, 2024
…le roles (#184529)

Closes #184116

## Summary

Update the text in the role deletion confirmation modal in Serverless to
clearly indicate possible consequences for users when multiple roles are
being deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Users/Roles/API Keys Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants