Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless] Update custom role deletion modal text to reflect multiple roles #184529

Merged
merged 2 commits into from
May 31, 2024
Merged

[Serverless] Update custom role deletion modal text to reflect multiple roles #184529

merged 2 commits into from
May 31, 2024

Conversation

SiddharthMantri
Copy link
Contributor

Closes #184116

Summary

Update the text in the role deletion confirmation modal in Serverless to clearly indicate possible consequences for users when multiple roles are being deleted.

@SiddharthMantri SiddharthMantri added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Users/Roles/API Keys release_note:skip Skip the PR/issue when compiling release notes labels May 30, 2024
@SiddharthMantri SiddharthMantri requested a review from a team as a code owner May 30, 2024 15:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 587.0KB 587.1KB +120.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@SiddharthMantri SiddharthMantri merged commit 5e8d3e8 into elastic:main May 31, 2024
17 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeramysoucy jeramysoucy jeramysoucy approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Users/Roles/API Keys release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update custom role delete modal to account for multiple role assignments
5 participants
@SiddharthMantri @elasticmachine @kibana-ci @jeramysoucy @kibanamachine