Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana should include the app title in the page title #7339

Closed
colings86 opened this issue Jun 1, 2016 · 6 comments
Closed

Kibana should include the app title in the page title #7339

colings86 opened this issue Jun 1, 2016 · 6 comments
Assignees
@cuff-links
Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@colings86
Copy link
Contributor

All apps except Console have a page title of 'Kibana'. Console overrides the page title to be 'Console - Kibana'.

I think we should set the page title in the Kibana platform and have it as ' - Kibana' as it is very useful to know which app you are in for a tab especially if you have multiple Kibana tabs open (which I often do).
@epixa epixa removed the P3 label Apr 25, 2017
@alexfrancoeur alexfrancoeur added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team labels Mar 7, 2018
@alexfrancoeur
Copy link

alexfrancoeur commented Mar 7, 2018 •
edited
Loading

@epixa being able to differentiate between Kibana tabs was a fairly common request at Elastic{ON} this year. The common ask was to be able to differentiate between kibana instances a bit better, but I think we need to improve titles of tabs in Kibana per application / dashboard as well. I'm not sure who would own this so I tagged Platform and Operations. @jimgoodwin was in agreement here also. Is this low hanging fruit that will seriously improve a number of our users lives?

For the multi-tenant differentiation, maybe we can have a setting in the kibana.yml file that would preface any tab with a custom name. For example, if you changed this setting to dev-env each tab would have dev-env: [TITLE OF APP OR DASHBOARD].

What do you think?

cc: @AlonaNadler

@epixa epixa removed the Team:Operations Team label for Operations Team label Mar 10, 2018
@epixa
Copy link
Contributor

epixa commented Mar 10, 2018

That all seems reasonable to me. This would be a platform thing, so I removed the ops label.

@epixa
Copy link
Contributor

epixa commented Mar 10, 2018

cc @kjbekkelund

@epixa epixa added the good first issue low hanging fruit label Apr 2, 2018
@cuff-links cuff-links self-assigned this May 4, 2018
@cuff-links
Copy link
Contributor

cuff-links commented May 5, 2018 •
edited
Loading

@epixa Question: We have a situation in the discover app where the title of the document is set to the saved object here so I would like to know how we would want this presented in the title. Would it be Discover - Kibana : {String for Saved Object} or some other variant of this?

@epixa
Copy link
Contributor

epixa commented May 5, 2018

Kibana is the least important part of title, so it should always come last. Our favicon indicates Kibana in browser tabs, so even if the word "Kibana" is pushed off of the tab due to space, the context is still there.

I can see an argument for app name coming before the title of the object. It's not uncommon to have many objects with very similar titles, so knowing the app name up front could be a useful way to distinguish these things.

On the other hand, the object title is the only thing that users have complete control over. We should probably err on the side of the user data on this one and put the saved object title up front.

So <object title> · <app name> · Kibana.

@epixa epixa added enhancement New value added to drive a business result and removed release_note:enhancement labels May 7, 2018
@timroes
Copy link
Contributor

timroes commented Apr 17, 2019

@epixa I consolidated all the document title issues (we also had two labeled on our team) into #35210. I would thus close this in favor of the new issue.

@timroes timroes closed this as completed Apr 17, 2019
jbudz pushed a commit that referenced this issue Dec 18, 2023
@tkajtoch @cee-chen
@kibanamachine @stratoula
Upgrade EUI to v91.0.0 (with backports) (#170716)
b043545 
`v90.0.0`⏩`v91.0.0-backport.0`

⚠️ While this upgrade pings many teams and has a large code diff, **the
majority of the changes are snapshots or tests-related** and do not
touch source code, so should theoretically only need a code review and
not dedicated QA.

The changes in EUI that required a large swathe of these updates are:

- **EuiPopover** removed an extra unnecessary `<div>` wrapper on its
anchors, which affected many snapshots and a few CSS overrides, which
should have been updated
- **EuiButtonGroup** now renders `<button>` elements instead of `<input
type="radio">` elements for single selection, which affected both
snapshots and E2E tests
- **EuiSuperDatePicker**'s absolute date input now requires an `Enter`
keypress when parsing dates (affected E2E tests)
- **EuiComboBox**, when rendered with `singleSelection={{ plainText:
'true' }}`, no longer renders a pill (i.e. text). This combobox type now
behaves more like an `EuiFieldText`, where the selection is rendered via
input `value` instead. This affected a high amount of E2E tests (both
FTR and Cypress), both in terms of updating assertions and changing
selections, but should **not** significantly affect user experience -
see elastic/eui#7332 for more.

---

##
[`v91.0.0-backport.0`](https://github.com/elastic/eui/tree/v91.0.0-backport.0)

**This is a backport release only intended for use by Kibana.**

- Added `esqlVis`, `pipeBreaks`, and `pipeNoBreaks` icon glyphs.
- `EuiSelectable` now allows configurable text truncation via
`listProps.truncationProps`
([#7388](elastic/eui#7388))
- `EuiTextTruncate` now supports a new `calculationDelayMs` prop for
working around font loading or layout shifting scenarios
([#7388](elastic/eui#7388))

**Bug fixes**

- Fixed a bug with `EuiSelectable`s with custom `truncationProps`, where
scrollbar widths were not being accounted for
([#7392](elastic/eui#7392))

## [`91.0.0`](https://github.com/elastic/eui/tree/v91.0.0)

- Updated the background color of `EuiPopover`s in dark mode to increase
visibility & contrast against other page/panel backgrounds
([#7310](elastic/eui#7310))
- Memoized `EuiDataGrid` to prevent unneeded re-renders
([#7324](elastic/eui#7324))
- Added a configurable `role` prop to `EuiAccordion`
([#7326](elastic/eui#7326))
- Added a configurable `role` prop to `EuiGlobalToastList`
([#7328](elastic/eui#7328))
- For greater flexibility, `EuiSuperDatePicker` now allows users to
paste ISO 8601, RFC 2822, and Unix timestamps in the `Absolute` tab
input, in addition to timestamps in the `dateFormat` prop
([#7331](elastic/eui#7331))
- Plain text `EuiComboBox`es now behave more like a normal text
field/input. Backspacing will no longer delete the entire value, and
selected values can now be double clicked and copied.
([#7332](elastic/eui#7332))
- `EuiDataGrid`'s display settings popover now allows users to clear the
"Lines per row" input before typing in a new number
([#7338](elastic/eui#7338))
- Improved the UX of `EuiSuperDatePicker`'s Absolute tab for users
manually typing in timestamps
([#7341](elastic/eui#7341))
- Updated `EuiI18n`s with multiple `tokens` to accept dynamic `values`
([#7341](elastic/eui#7341))

**Bug fixes**

- Fixed `EuiComboBox`'s `onSearchChange` callback to pass the correct
`hasMatchingOptions` value
([#7334](elastic/eui#7334))
- Fixed an `EuiSelectableTemplateSitewide` bug where the `popoverButton`
behavior would break if passed a non-DOM React wrapper
([#7339](elastic/eui#7339))

**Deprecations**

- `EuiPopover`: deprecated `anchorClassName`. Use `className` instead
([#7311](elastic/eui#7311))
- `EuiPopover`: deprecated `buttonRef`. Use `popoverRef` instead
([#7311](elastic/eui#7311))
- `EuiPopover`: removed extra `.euiPopover__anchor` div wrapper. Target
`.euiPopover` instead if necessary
([#7311](elastic/eui#7311))
- Deprecated `EuiButtonGroup`'s `name` prop. This can safely be removed.
([#7325](elastic/eui#7325))

**Breaking changes**

- Removed deprecated `euiPaletteComplimentary` - use
`euiPaletteComplementary` Instead
([#7333](elastic/eui#7333))

**Accessibility**

- Updated `type="single"` `EuiButtonGroup`s to render standard buttons
instead of radio buttons under the hood, per recent a11y recommendations
([#7325](elastic/eui#7325))
- `EuiAccordion` now defaults to a less screenreader-noisy `group` role
instead of `region`. If your accordion contains significant enough
content to be a document landmark role, you may re-configure it back to
`region`. ([#7326](elastic/eui#7326))
- Reduced screen reader noisiness when sorting `EuiDataGrid` columns via
toolbar ([#7327](elastic/eui#7327))
- `EuiGlobalToastList` now defaults to a `log` role. If your toasts will
always require immediate user action, consider (with caution) using the
`alert` role instead.
([#7328](elastic/eui#7328))

**CSS-in-JS conversions**

- Updated `$euiFontFamily` and `$euiCodeFontFamily` to match Emotion
fonts ([#7332](elastic/eui#7332))

---------

Co-authored-by: Cee Chen <constance.chen@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuff-links cuff-links

Labels
enhancement New value added to drive a business result good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@epixa @colings86 @timroes @cuff-links @alexfrancoeur