[Reporting] remove legacy pdf shim #121369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
Breaking Change
release_note:breaking
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
commented
Dec 16, 2021
| objects: relativeUrls.map((u) => ({ relativeUrl: u })), | ||
| // return the payload | ||
| return { | ||
| ...jobParams, |
There was a problem hiding this comment.
I noticed this should have isDeprecated: true since we have a V2 type for this. I'm leaving that as a separate issue: #121365
tsullivan
commented
Dec 16, 2021
| @@ -110,7 +110,7 @@ describe('Handle request to generate', () => { | |||
| "kibana_name": undefined, | |||
| "max_attempts": undefined, | |||
| "meta": Object { | |||
| "isDeprecated": false, | |||
| "isDeprecated": undefined, | |||
There was a problem hiding this comment.
This is not exactly correct (should be true since there is a V2 type), but is related to #121365
tsullivan
commented
Dec 16, 2021
| import { ReportingUsageStats } from '../services/usage'; | ||
|
|
||
| // These all have the domain name portion stripped out. The api infrastructure assumes it when we post to it anyhow. |
There was a problem hiding this comment.
Review note: Now that the shim is removed, this URLs are only used in this file, so I removed the entire GenerationUrls service to inline the URLs in this file.
vadimkibana
approved these changes
Dec 17, 2021
|
@elasticmachine merge upstream |
2 tasks
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
* [Reporting] remove legacy pdf shim * remove supporting files for deprecated type * cleanup generation URLs that are only used for usage * fix ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #120192
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release note:
Breaking change: POST URLs generated for PDF reports in Kibana 6.2 will no longer work. Please regenerate the POST URLs that you need for automating reports.