Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] remove legacy csv export type #121435

Merged
merged 19 commits into from
Dec 21, 2021

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Dec 16, 2021

Summary

Closes #121259

The initial CSV export implementation for Reporting in Kibana has been deprecated: #89794

The implementation was still available for users that have configured automated reports that were carried over after upgrading. We've added a sufficient amount of warnings in the UI when this type of export was found. We've studied telemetry data and found that less than 1% of reporting clusters are creating new exports with this type in versions where the replacement implementation is available.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Release Note

The /api/reporting/generate/csv endpoint has been removed. This affects users that have set up automated reporting for CSV exports in 7.13 and below. Please regenerate the POST URLs that you need for automating csv reports.

@tsullivan tsullivan requested review from a team as code owners December 16, 2021 17:40
@tsullivan tsullivan added Breaking Change (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:breaking Team:AppServicesUx labels Dec 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@tsullivan tsullivan added v8.1.0 backport:skip This commit does not require backporting labels Dec 16, 2021
@tsullivan tsullivan requested review from a team as code owners December 16, 2021 22:50
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

merged #121369 into this branch to handle conflicts

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #10 / Actions and Triggers app Rule Details Edit rule button should open edit rule flyout

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 01d74cf into elastic:main Dec 21, 2021
@tsullivan tsullivan deleted the reporting/deprecated-csv-removal branch December 21, 2021 18:29
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
* [Reporting] remove legacy pdf shim

* remove supporting files for deprecated type

* cleanup generation URLs that are only used for usage

* remove legacy csv export type

* fix a11y test

* fix bwc test

* fix ts

* fix test snapshot

* fix test

* fix telemetry mappings

* fix a11y test

* fix unused t10s

* fix ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
wayneseymour added a commit to wayneseymour/kibana that referenced this pull request Oct 11, 2024
Contributes to: elastic#194817

Why I assigned them:

Assigned advanced_settings due to elastic#175255

Assigned dashboard_controls due to elastic#190797

Assigned dashboard_links due to elastic#174772

Assigned dashboard_panel_options due to elastic#178596

Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned helpers due to elastic#164341 (call site)

Assigned home due to elastic#103192

Assigned index_lifecycle_management due to elastic#116207

Assigned ingest_node_pipelines due to elastic#113783

Assigned kibana_overview due to  https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned management due to elastic#165705

Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4

Assigned search_profiler due to elastic#195343

Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4

Assigned lens due to elastic#175893

Assigned ml_anomaly_detection due to elastic#162126

Assigned canvas due to elastic#164376

Assigned cc replication due to elastic#149069

Assigned enterpise search due to elastic#79359

Assigned graph to due elastic#190797

Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4

Assigned maps due to elastic#155161

Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4

Assigned remote clusters due to elastic#96989

Assigned reporting due to elastic#121435

Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4

Assigned watcher due to elastic#119717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Breaking Change (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:breaking v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reporting] Legacy CSV export type can be removed
6 participants