Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allows passing multiple dataviews to buildEsQuery #140162

Merged
merged 8 commits into from
Sep 14, 2022
Merged

allows passing multiple dataviews to buildEsQuery #140162

merged 8 commits into from
Sep 14, 2022

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Sep 7, 2022 •
edited
Loading

Summary

resolves #119282

Checklist

Delete any items that are not applicable to this PR.

@ppisljar ppisljar requested a review from a team as a code owner September 7, 2022 08:36
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.5.0 labels Sep 7, 2022
Dosant
Dosant approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
just a perf suggestion that makes sense in case this function can be used with all the data views available in Kibana. if it is used with a small list only, then never mind.

packages/kbn-es-query/src/es_query/from_filters.ts Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 479.7KB 479.9KB +213.0B
cloudSecurityPosture 200.1KB 200.3KB +213.0B
controls 457.8KB 458.0KB +213.0B
dashboard 369.1KB 369.3KB +213.0B
dataViewManagement 147.3KB 147.5KB +213.0B
dataVisualizer 565.8KB 566.0KB +213.0B
discover 464.8KB 465.0KB +213.0B
discoverEnhanced 43.3KB 43.5KB +213.0B
infra 1016.2KB 1016.4KB +213.0B
lens 1.2MB 1.2MB +213.0B
ml 3.3MB 3.3MB +213.0B
observability 520.7KB 520.9KB +213.0B
threatIntelligence 66.6KB 66.8KB +213.0B
transform 387.2KB 387.4KB +213.0B
unifiedFieldList 47.6KB 47.8KB +213.0B
unifiedSearch 233.7KB 233.9KB +213.0B
visTypeTimelion 107.7KB 107.9KB +213.0B
visTypeVega 1.7MB 1.7MB +213.0B
total +3.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 430.7KB 430.9KB +213.0B
securitySolution 260.2KB 260.4KB +213.0B
timelines 260.0KB 260.2KB +213.0B
total +639.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit 59ea09f into elastic:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiple data views for buildEsQuery
4 participants
@ppisljar @kibana-ci @Dosant @kibanamachine