[Custom threshold] Reintroduce no data setting in the custom threshold rule #188300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
release_note:skip
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
| @@ -164,7 +164,8 @@ describe('Expression', () => { | |||
| it('should prefill the rule using the context metadata', async () => { | |||
| const index = 'changedMockedIndex'; | |||
| const currentOptions: CustomThresholdPrefillOptions = { | |||
| alertOnGroupDisappear: false, | |||
| alertOnGroupDisappear: true, | |||
There was a problem hiding this comment.
Could we get rid of the alertOnGroupDisappear and just use alertOnNoData for both with and without group? Since it's now mapped to a single checkbox it seems odd to keep two separate values on our schema. Or do we need to support this for backwards compatibility?
There was a problem hiding this comment.
Yes, we need to support this for backward compatibility. I've added this item to be considered for the v9 release. (i.e. removing alertOnGroupDisappear and only using alertOnNoData)
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
added
v8.16.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188229, related to #183921, and #184465
Documentation request: elastic/observability-docs#4068
Summary
Note: I've added an item to deprecate/remove one of the no-data settings in v9.
Fixes not showing no data setting and set the related settings to false by default. Based on @maciejforcone's input, we can combine these 2 settings for simplicity, as one of them works at a time.
I also changed the tooltip according to which setting is relevant: (we use one action group for both of them in connectors)
Here is how the setting is applied in API:
Screen.Recording.2024-07-15.at.13.03.00.mov