Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[canvas][storybook] Improve Storybook Performance #34757
Storybook performance has been pretty poor compared to my past experiences, so I started digging into the details. After chatting and filing an issue with the Storybook dev team, there was an issue with
In addition, with the help of @spalger, I was able to offload almost all of the 10MB+ of code dependencies into a DLL, leaving only a couple of MB of Canvas and Storybook code behind.
All considered, this PR drops the Canvas Storybook build time from 1.5 minutes to 9 seconds.
This PR also includes:
Love the speed improvements!
There is already a watcher implemented for Kibana development used here: https://github.com/elastic/kibana/blob/master/src/legacy/server/sass/index.js#L82 It handles a few cases which are not covered, like watching dependencies outside the directory. Think you could generalize the code there for use in both the dev server and plugin build?