[Drilldowns] Dashboard to dashboard drilldown #63108

Dosant · 2020-04-09T12:48:03Z

Summary

PR is not into master, but into Drilldowns branch: #61219

Addresses: #55322 - implements Dashboard to dashboard drilldown
Continuation of #60087

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…kibana into drilldowns_load_dashboard_list

…ad_dashboard_list

except for back button - that would be addressed separatly

we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull

…kibana into drilldowns_load_dashboard_list

…downs/drilldowns_load_dashboard_list

fix type

Dosant · 2020-04-22T11:30:47Z

...es/drilldowns/dashboard_to_dashboard_drilldown/components/dashboard_drilldown_config/i18n.ts

+export const txtUseCurrentFilters = i18n.translate(
+  'xpack.dashboard.components.DashboardDrilldownConfig.useCurrentFilters',
+  {
+    defaultMessage: 'Use filters and query from origin dashboard',


Original wording was: Use filters from current dashboard,

We discussed this on one of dev meetings.
Concerns we had:

By just filters we understood filter pills, but not search query in the query bar. But we also agreed to pass along query string. so we hoped filters and query would be better as it is more explicit

We had push back on word current because in context of editing drilldown it wasn’t clear what we mean by current. Is it dashboard which we are in or is it currently selected dashboard in Combobox? So we decided to try to use origin instead. Like pair: origin <-> destination

Hope this is OK

mdefazio · 2020-04-22T11:32:04Z

LGTM!

Dosant · 2020-04-22T16:29:13Z

src/plugins/dashboard/public/application/actions/clone_panel_action.tsx

@@ -39,7 +39,7 @@ export interface ClonePanelActionContext {
 export class ClonePanelAction implements ActionByType<typeof ACTION_CLONE_PANEL> {
  public readonly type = ACTION_CLONE_PANEL;
  public readonly id = ACTION_CLONE_PANEL;
-  public order = 11;
+  public order = 45;


Adjusted to follow: #60138 (comment)

andreadelrio

LGTM

streamich

nice work on functional tests, LGTM, checked on Mac/Chrome

…downs/drilldowns_load_dashboard_list # Conflicts: # src/plugins/data/public/public.api.md

stacey-gammon

looks good! code review, only but will def be playing around with the whole thing soon.

stacey-gammon · 2020-04-23T19:56:13Z

..._enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.tsx

@@ -69,6 +69,7 @@ export class FlyoutEditDrilldownAction implements ActionByType<typeof OPEN_FLYOU
      ),
      {
        ownFocus: true,
+        'data-test-subj': 'dashboardEditDrilldownFlyout',


Would we need to create new drilldown flyouts if we wanted to let canvas users configure drilldowns? Can't remember what the plan was with that. Just thinking, if we do eventually make these generic, this name wouldn't make sense anymore.

It looks like we indeed should move those 2 actions from dashboard_enhanced into embeddable_enchanced.

Changed that test-subj name to remove the only dashboard specific thing :)

...services/drilldowns/dashboard_to_dashboard_drilldown/components/collect_config_container.tsx

stacey-gammon · 2020-04-23T20:04:03Z

...services/drilldowns/dashboard_to_dashboard_drilldown/components/collect_config_container.tsx

+
+    // bail out if this response is no longer needed
+    if (!this.isMounted) return;
+    if (searchString !== this.state.searchString) return;


Nice, leaving this line out was a source of bugs in the past. ✅

stacey-gammon · 2020-04-23T20:18:53Z

...oard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx

+import { esFilters } from '../../../../../../../src/plugins/data/public';
+
+// convenient to use real implementation here.
+import { createDirectAccessDashboardLinkGenerator } from '../../../../../../../src/plugins/dashboard/public/url_generator';


I'm surprised this isn't throwing an error for invalid deep import.

Tests are excluded from that rule

...oard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx

stacey-gammon · 2020-04-23T20:34:14Z

...oard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.test.tsx

+
+    expect(href).toEqual(expect.stringContaining(existingAppFilterKey));
+    expect(href).toEqual(expect.stringContaining(existingGlobalFilterKey));
+    expect(href).toEqual(expect.stringContaining(newAppliedFilterKey));


Are filters that are saved with the destination dashboard preserved? There are three filters: dynamic filters, filters on source dashboard, and filters on destination dashboard. If you say yes to filters on current dashboard, will the final filters be all three or are the destination filters replaced?

Just checked. Looks like no. If there is _a in the dashboard url, then that state takes precedence.
And this is tricky. I imagine If I share a url to dashboard, I'd expect receiver to see the same filters, which I am seeing 🤔. And this how it is right now. - so IMO dashboard restoring state from the URL is correct.

I was trying to avoid it, but looks like we will have to pull in destination dashboard inside dashboard_to_dashboard_drilldown to get it's saved filters and to put them into destination URL, correct?

Good thing, this will also improve error handling for cases when destination dashboard no longer exist and will not navigate user to not existing dashboard.

Agree?

Yep, that's what I was thinking as well.

@stacey-gammon, thinking a bit more about it:

Initially I though to pull in destination dashboard inside the dashboard_drilldown code and pass merged filters into url generator.
But know I am realising the this is likely most common scenario? Whoever uses dashboard url generator wants to preserve original filters also. And it seems it would be too much burden for every consumer to retrieve saved filters before using url generator.
So options:

Option 1: retrieve saved filters in Drilldowns code. Pass all filters to url generator

Option 2: retrieve saved filters inside url generator. merge them with incoming filters when generating url

Option 3: Url generator optionally adds additional flag in the url to also preserve saved filters: e.g. &savedFilters=merge. When dashboard is loaded it will use that flag to decided what to do with filters saved in dashboard.

I am leaning towards Option 3, because less dependencies inside url generator (no need to pull in saved object) and generated url does not contain snapshot of filters, but will retrieve the ones which are saved with dashboard when dashboard is opened.

What do you think?

Option 3 sounds okay, we should ask @ThomThomson and @majagrubic to weigh in though since ultimately this is their code to maintain.

-- brain dump --

I am really a bit torn on Option 2 vs 3. Where do we want the bulk of the logic to reside - url generators or apps handling a slew of different url parameters? If you keep your URL parameters to a minimum, it feels easier to maintain and migrate. We don't have a version number stored with the URL, but we do with the url generator state (via the id, though we probably should change it to accept an actual version number).

Say we wanted to split savedFilters=merge into two parameters, one for the query and one for filter pills. There is a clear path forward for how to do that with URL generators. The migration logic is encapsulated in one place. Dashboard app code doesn't get littered with a bunch of extra "ifs" to try to figure out what URL parameters are in there. There is no chance of having to figure out how to handle a URL mixed with legacy and the new parameters.

I don't think we have a good story, outside of URL generators, for deprecating/migrating urls. I might be wrong though, if this is where state containers comes into play. Every time I have a conversation with @lukeelmers about url generators vs state containers, I feel like I am lacking a solid understanding of the state containers.

So, I think we can move forward either way without blocking ourselves in, but it's on my todo list to try to clarify this problem of URL migrations.

Url generator optionally adds additional flag in the url to also preserve saved filters: e.g. &savedFilters=merge. When dashboard is loaded it will use that flag to decided what to do with filters saved in dashboard.

UX question - Is there ever a scenario in dashboard view mode where we wouldn't want to preserve saved filters & merge in any incoming ones which are new? I agree with @Dosant that it is reasonable for a user saving a dashboard with filters to expect those filters to be preserved when anybody returns to the dashboard. So I guess I'm wondering why we'd need to add a savedFilters=merge param at all, vs making this the standard behavior for URLs in the dashboard app.

If a dashboard owner saves it with filters, I think it is an acceptable tradeoff that those filters cannot be wiped out by new filters coming in from a drilldown. I would expect you to be able to add new ones, but not fundamentally alter the existing dashboard.

Edit mode might be a different story, IDK. Perhaps there's a use case for overriding saved filters in that case since they are being edited.

--- everything below is a tangent based on stacey's brain dump above ---

I don't think we have a good story, outside of URL generators, for deprecating/migrating urls.

My two cents on this is that things are going to become overly complex if the concept of url state/migrations somehow diverges from the concept of persistable state/migrations in general. IMO the proposed persistable state registry & the idea for persistable state migrations should also serve as the solution to dealing with migrations in urls.

So in that regard, I don't think we need a migration solution which is specific to URLs in the long run: The URLs are a reflection of an application's internal persistable state, not the single source of truth for state, so when we talk about migration of URLs, what we are actually talking about is migration of state.

Most likely, this means either removing migrations as a concept from the URL generators, or having authors of those migrations use persistable states registry under the hood. But I 💯 agree with @stacey-gammon that we need to work to articulate a clearer story of how state migrations apply to URLs more broadly. This should be a design consideration for the persistable states registry work.

Is there ever a scenario in dashboard view mode where we wouldn't want to preserve saved filters & merge in any incoming ones which are new?

I think the situation we need to be sure to handle is:

User opens dashboard 123 with saved filter: country:US

User removes country:US filter, in view mode.

That is handled by using the filters in the URL as the source of truth. I don't see how we could represent that state, in view mode, if it was only allowed to be additive.

This makes me lean more towards Option 2 as a better route because of these subtleties. If you open up a dashboard with savedFilters=merge, will dashboard load up, merge the filters, and remove that parameter? If it stays in the URL, how could the user then delete a filter in view mode?

IMO the proposed persistable state registry & the idea for persistable state migrations should also serve as the solution to dealing with migrations in urls.

100% agree with this. Adding this URL specific migration code was me experimenting with migrations in a pre-persistable state registry world, knowing that as soon as a generic solution was available, URL generators would use that instead of it's own system.

@stacey-gammon,

This makes me lean more towards Option 2 as a better route because of these subtleties. If you open up a dashboard with savedFilters=merge, will dashboard load up, merge the filters, and remove that parameter?

Yes, I was planning to remove the parameter using history.replace when dashboard is loaded.

What I don't like about Option2 is that we will have to handle inside url generator scenario when dashboard with id is missing. Or handle any other error where we wasn't able to load the saved object. Should we in this case just swallow the error and don't add any additional filters into the url? Or should we throw an error, so don't generate any url?
I'd prefer to try to not to do any of that inside the url generator and leave it to dashboard app instead

What I don't like about Option2 is that we will have to handle inside url generator scenario when dashboard with id is missing. Or handle any other error where we wasn't able to load the saved object. Should we in this case just swallow the error and don't add any additional filters into the url?

🤔

hmm, what is the proper way to handle errors in these url generators is a good question. You could return the dashboard listing page url, though you'd have to manually pop up the "missing dashboard" notification. So I'd probably just swallow the error and not add any filters, and return the url to the dashboard with the id which would then just redirect to the landing page and show the "missing dashboard" notification. But I admit, I don't love that flow.

I still think that there is more overhead and exposure in adding this to the URL, which is a public contract that needs to be maintained and tested. We were just talking in the tech lead sync today about URLs and how, if we want to strive to get to a place where all the address bar URLs are BWC for minimum one major, ideally longer, we should be putting less information in them.

It's easy to write unit tests for this URL generator based on different input parameters (what happens if the id is missing), but there is no way easy way to write unit tests for all the url parameters dashboard app should handle. You'd have to write a functional test to cover it, and those are slower, and you'd need to write a lot of them to cover everything (what happens if I use a non-existant id and have this new parameter set to true, set to false, what if I use this setting in view mode, in edit mode, etc).

Ultimately I leave it up to the final maintainers of this code, which are @ThomThomson and @majagrubic.

@stacey-gammon, fyi

@majagrubic also considers Option 2 better: #64633 (comment)

So I went with Option 2 here: #64767

stacey-gammon · 2020-04-23T20:39:16Z

...dashboard_enhanced/public/services/drilldowns/dashboard_to_dashboard_drilldown/drilldown.tsx

+      }
+    }
+
+    return getUrlGenerator(DASHBOARD_APP_URL_GENERATOR).createUrl({


nit: If we move forward with the recommendation here: #62815, this should probably just access the dashboard url generator directly from the dashboard plugin, rather than use the generic accessor.

So export url generator on a dashboard plugin contract and use it in dashboard_enchanched? Correct?
I'll go for it in follow up pr

yep, and sg

@stacey-gammon, pls review: #64628

stacey-gammon · 2020-04-23T20:43:18Z

x-pack/test/functional/es_archives/dashboard/drilldowns/mappings.json

@@ -0,0 +1,244 @@
+{


Did you try reusing existing archived data? Wondering why you needed to create a new archive (don't want to duplicate data that adds to repo size, unless there is a reason)

@stacey-gammon, I decided to prepare convenient data upfront. there are:

2 dashboards:

with pie chart to test value click action

with area chart to test range select action. - this one contains preconfigured drilldown - to make sure we don't break drilldowns created in 7.8 in future versions.

kibanamachine · 2020-04-24T07:10:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8ec37f5

History

💚 Build #42727 succeeded 0997398
💚 Build #42526 succeeded 218d66f
💚 Build #42408 succeeded 8566cbc
💚 Build #42372 succeeded 6e1d768
💚 Build #42113 succeeded 8c4e836

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

streamich · 2020-04-27T06:35:19Z

To continue that conversation about URL generator's return value, I guess we should not hard-code "kibana" in navigateTo call but extract it from URL returned by URL generator.

If URL generator would return a structured object we would not need to parse out the "kibana" string.

Dosant · 2020-04-27T06:59:38Z

@streamich, afaik, very soon kibana in the url will just go away (#61304). Url generator just already generates newer urls. Suggest just to wait a bit and see where we end up after #61304

@mdefazio

* Add drilldown wizard components * Dynamic actions (#58216) * feat: 🎸 add DynamicAction and FactoryAction types * feat: 🎸 add Mutable<T> type to @kbn/utility-types * feat: 🎸 add ActionInternal and ActionContract * chore: 🤖 remove unused file * feat: 🎸 improve action interfaces * docs: ✏️ add JSDocs * feat: 🎸 simplify ui_actions interfaces * fix: 🐛 fix TypeScript types * feat: 🎸 add AbstractPresentable interface * feat: 🎸 add AbstractConfigurable interface * feat: 🎸 use AbstractPresentable in ActionInternal * test: 💍 fix ui_actions Jest tests * feat: 🎸 add state container to action * perf: ⚡️ convert MenuItem to React component on Action instance * refactor: 💡 rename AbsractPresentable -> Presentable * refactor: 💡 rename AbstractConfigurable -> Configurable * feat: 🎸 add Storybook to ui_actions * feat: 🎸 add <ErrorConfigureAction> component * feat: 🎸 improve <ConfigureAction> component * chore: 🤖 use .story file extension prefix for Storybook * feat: 🎸 improve <ErrorConfigureAction> component * feat: 🎸 show error if dynamic action has CollectConfig missing * feat: 🎸 render sample action configuration component * feat: 🎸 connect action config to <ConfigureAction> * feat: 🎸 improve <ConfigureAction> stories * test: 💍 add ActionInternal serialize/deserialize tests * feat: 🎸 add ActionContract * feat: 🎸 split action Context into Execution and Presentation * fix: 🐛 fix TypeScript error * refactor: 💡 extract state container hooks to module scope * docs: ✏️ fix typos * chore: 🤖 remove Mutable<t> type * test: 💍 don't cast to any getActions() function * style: 💄 avoid using unnecessary types * chore: 🤖 address PR review comments * chore: 🤖 rename ActionContext generic * chore: 🤖 remove order from state container * chore: 🤖 remove deprecation notice on getHref * test: 💍 fix tests after order field change * remove comments Co-authored-by: Matt Kime <matt@mattki.me> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Drilldown context menu (#59638) * fix: 🐛 fix TypeScript error * feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger * fix: 🐛 correctly order context menu items * fix: 🐛 set correct order on drilldown flyout actions * fix: 🐛 clean up context menu building functions * feat: 🎸 add context menu separator action * Add basic ActionFactoryService. Pass data from it into components instead of mocks * Dashboard x pack (#59653) * feat: 🎸 add dashboard_enhanced plugin to x-pack * feat: 🎸 improve context menu separator * feat: 🎸 move drilldown flyout actions to dashboard_enhanced * fix: 🐛 fix exports from ui_actions plugin * feat: 🎸 "implement" registerDrilldown() method * fix ConfigurableBaseConfig type * Implement connected flyout_manage_drilldowns component * Simplify connected flyout manage drilldowns component. Remove intermediate component * clean up data-testid workaround in new components * Connect welcome message to storage Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped. * require `context` in Presentable. drill context down through wizard components * Drilldown factory (#59823) * refactor: 💡 import storage interface from ui_actions plugin * refactor: 💡 make actions not-dynamic * feat: 🎸 fix TypeScript errors, reshuffle types and code * fix: 🐛 fix more TypeScript errors * fix: 🐛 fix TypeScript import error * Drilldown registration (#59834) * feat: 🎸 improve drilldown registration method * fix: 🐛 set up translations for dashboard_enhanced plugin * Drilldown events 3 (#59854) * feat: 🎸 add serialize/unserialize to action * feat: 🎸 pass in uiActions service into Embeddable * feat: 🎸 merge ui_actions oss and basic plugins * refactor: 💡 move action factory registry to OSS * fix: 🐛 fix TypeScript errors * Drilldown events 4 (#59876) * feat: 🎸 mock sample drilldown execute methods * feat: 🎸 add .dynamicActions manager to Embeddable * feat: 🎸 add first version of dynamic action manager * Drilldown events 5 (#59885) * feat: 🎸 display drilldowns in context menu only on one embed * feat: 🎸 clear dynamic actions from registry when embed unloads * fix: 🐛 fix OSS TypeScript errors * basic integration of components with dynamicActionManager * fix: 🐛 don't overwrite explicitInput with combined input (#59938) * display drilldown count in embeddable edit mode * display drilldown count in embeddable edit mode * improve wizard components. more tests. * partial progress, dashboard drilldowns (#59977) * partial progress, dashboard drilldowns * partial progress, dashboard drilldowns * feat: 🎸 improve dashboard drilldown setup * feat: 🎸 wire in services into dashboard drilldown * chore: 🤖 add Storybook to dashboard_enhanced * feat: 🎸 create presentational <DashboardDrilldownConfig> * test: 💍 add <DashboardDrilldownConfig> stories * test: 💍 use presentation dashboar config component * feat: 🎸 wire in services into React component * docs: ✏️ add README to /components folder * feat: 🎸 increase importance of Dashboard drilldown * feat: 🎸 improve icon definition in drilldowns * chore: 🤖 remove unnecessary comment * chore: 🤖 add todos Co-authored-by: streamich <streamich@gmail.com> * Manage drilldowns toasts. Add basic error handling. * support order in action factory selector * fix column order in manage drilldowns list * remove accidental debug info * bunch of nit ui fixes * Drilldowns reactive action manager (#60099) * feat: 🎸 improve isConfigValid return type * feat: 🎸 make DynamicActionManager reactive * docs: ✏️ add JSDocs to public mehtods of DynamicActionManager * feat: 🎸 make panel top-right corner number badge reactive * fix: 🐛 correctly await for .deleteEvents() * Drilldowns various 2 (#60103) * chore: 🤖 address review comments * test: 💍 fix embeddable_panel.test.tsx tests * chore: 🤖 clean up ActionInternal * chore: 🤖 make isConfigValid a simple predicate * chore: 🤖 fix TypeScript type errors * test: 💍 stub DynamicActionManager tests (#60104) * Drilldowns review 1 (#60139) * refactor: 💡 improve generic types * fix: 🐛 don't overwrite icon * fix: 🐛 fix x-pack TypeScript errors * fix: 🐛 fix TypeScript error * fix: 🐛 correct merge * Drilldowns various 4 (#60264) * feat: 🎸 hide "Create drilldown" from context menu when needed * style: 💄 remove AnyDrilldown type * feat: 🎸 add drilldown factory context * chore: 🤖 remove sample drilldown * fix: 🐛 increase spacing between action factory picker * workaround issue with closing flyout when navigating away Adds overlay just like other flyouts which makes this defect harder to bump in * fix react key issue in action_wizard * don’t open 2 flyouts * fix action order #60138 * Drilldowns reload stored (#60336) * style: 💄 don't use double equals __ * feat: 🎸 add reload$ to ActionStorage interface * feat: 🎸 add reload$ to embeddable event storage * feat: 🎸 add storage syncing to DynamicActionManager * refactor: 💡 use state from DynamicActionManager in React * fix: 🐛 add check for manager being stopped * Drilldowns triggers (#60339) * feat: 🎸 make use of supportedTriggers() * feat: 🎸 pass in context to configuration component * feat: 🎸 augment factory context * fix: 🐛 stop infinite re-rendering * Drilldowns multitrigger (#60357) * feat: 🎸 add support for multiple triggers * feat: 🎸 enable Drilldowns for TSVB Although TSVB brushing event is now broken on master, KibanaApp plans to fix it in 7.7 * "Create drilldown" flyout - design cleanup (#60309) * create drilldown flyout cleanup * remove border from selectedActionFactoryContainer * adjust callout in DrilldownHello * update form labels * remove unused file * fix type error Co-authored-by: Anton Dosov <anton.dosov@elastic.co> * basic unit tests for flyout_create_drildown action * Drilldowns finalize (#60371) * fix: 🐛 align flyout content to left side * fix: 🐛 move context menu item number 1px lower * fix: 🐛 move flyout back nav chevron up * fix: 🐛 fix type check after refactor * basic unit tests for drilldown actions * Drilldowns finalize 2 (#60510) * test: 💍 fix test mock * chore: 🤖 remove unused UiActionsService methods * refactor: 💡 cleanup UiActionsService action registration * fix: 🐛 add missing functionality after refactor * test: 💍 add action factory tests * test: 💍 add DynamicActionManager tests * feat: 🎸 capture error if it happens during initial load * fix: 🐛 register correctly CSV action * feat: 🎸 don't show "OPTIONS" title on drilldown context menus * feat: 🎸 add server-side for x-pack dashboard plugin * feat: 🎸 disable Drilldowns for TSVB * feat: 🎸 enable drilldowns on kibana.yml feature flag * feat: 🎸 add feature flag comment to kibana.yml * feat: 🎸 remove places from drilldown interface * refactor: 💡 remove place in factory context * chore: 🤖 remove doExecute * remove not needed now error_configure_action component * remove workaround for storybook * feat: 🎸 improve DrilldownDefinition interface * style: 💄 replace any by unknown * chore: 🤖 remove any * chore: 🤖 make isConfigValid return type a boolean * refactor: 💡 move getDisplayName to factory, remove deprecated * style: 💄 remove any * feat: 🎸 improve ActionFactoryDefinition * refactor: 💡 change visualize_embeddable params * feat: 🎸 add dashboard dependency to dashboard_enhanced * style: 💄 rename drilldown plugin life-cycle contracts * refactor: 💡 do naming adjustments for dashboard drilldown * fix: 🐛 fix Type error * fix: 🐛 fix TypeScript type errors * test: 💍 fix test after refactor * refactor: 💡 rename context -> placeContext in React component * chore: 🤖 remove setting from kibana.yml * refactor: 💡 change return type of getAction as per review * remove custom css per review * refactor: 💡 rename drilldownCount to eventCount * style: 💄 remove any * refactor: 💡 change how uiActions are passed to vis embeddable * style: 💄 remove unused import * fix: 🐛 pass in uiActions to visualize_embeddable * fix: 🐛 correctly register action * fix: 🐛 fix type error * chore: 🤖 remove unused translations * Dynamic actions to xpack (#62647) * feat: 🎸 set up sample action factory provider * feat: 🎸 create dashboard_enhanced plugin * feat: 🎸 add EnhancedEmbeddable interface * refactor: 💡 move DynamicActionManager to x-pack * feat: 🎸 connect dynamic action manager to embeddable life-cycle * test: 💍 fix Jest tests after refactor * fix: 🐛 fix type error Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * refactor: 💡 move action factories to x-pack (#63190) * refactor: 💡 move action factories to x-pack * fix: 🐛 use correct plugin embeddable deps * test: 💍 fix Jest test after refactor * chore: 🤖 remove kibana.yml flag (#62441) * Panel top right (#63466) * feat: 🎸 add PANEL_NOTIFICATION_TRIGGER * feat: 🎸 add PanelNotificationsAction action * test: 💍 add PanelNotificationsAction unit tests * refactor: 💡 revert addTriggerAction() change * style: 💄 remove unused import * fix: 🐛 fix typecheck errors after merge * support getHref in drilldowns (#63727) * chore: 🤖 remove ui_actions storybook config * update docs * fix ts * fix: 🐛 fix broken merge * [Drilldowns] Dashboard to dashboard drilldown (#63108) * partial progress on async loading / searching of dashboard titles * feat: 🎸 make combobox full width * filtering combobox polish * storybook fix * implement navigating to dashboard, seems like a type problem * try navToApp * filter out current dashboard * rough draft linking to a dashboard * remove note * typefix * fix navigation from dashboard to dashboard except for back button - that would be addressed separatly * partial progress getting filters from action data * fix issue with getIndexPatterns undefined we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull * fix filter / time passing into url * typefix * dashboard to dashboard drilldown functional test and back button fix * documentation update * chore clean-ups fix type * basic unit test for dashboard drilldown * remove test todos decided to skip those tests because not clear how to test due to EuiCombobox is using react-virtualized and options list is not rendered in jsdom env * remove config * improve back button with filter comparison tweak * dashboard filters/date option off by default * revert change to config/kibana.yml * remove unneeded comments * use default time range as appropriate * fix type, add filter icon, add text * fix test * change how time range is restored and improve back button for drilldowns * resolve conflicts * fix async compile issue * remove redundant test * wip * wip * fix * temp skip tests * fix * handle missing dashboard edge case * fix api * refactor action filter creation utils * updating * updating docs * improve * fix storybook * post merge fixes * fix payload emitted in brush event * properly export createRange action * improve tests * add test * post merge fixes * improve * fix * improve * fix build * wip getHref support * implement getHref() * give proper name to a story * use sync start services * update text * fix types * fix ts * fix docs * move clone below drilldowns (near replace) * remove redundant comments * refactor action filter creation utils * updating * updating docs * fix payload emitted in brush event * properly export createRange action * some more updates * fixing types * ... * inline EventData * fix typescript in lens and update docs * improve filters types * docs * merge * @mdefazio review * adjust actions order * docs * @stacey-gammon review Co-authored-by: Matt Kime <matt@mattki.me> Co-authored-by: streamich <streamich@gmail.com> Co-authored-by: ppisljar <peter.pisljar@gmail.com> * fix docs * nit fixes * chore: 🤖 remove uiActions from Embeddable dependencies * chore: 🤖 don't export ActionInternal from ui_actions * test: 💍 remove uiActions deps in x-pack test mocks * chore: 🤖 cleanup ui_actions types * docs: ✏️ add JSDoc comment to addTriggerAction() * docs: ✏️ regenerate docs * Drilldown demo 2 (#64300) * chore: 🤖 add example of Discover drilldown to sample plugin * fix: 🐛 show drilldowns with higher "order" first * feat: 🎸 add createStartServicesGetter() to /public kibana_util * feat: 🎸 load index patterns in Discover drilldown * feat: 🎸 add toggle for index pattern selection * feat: 🎸 add spacer to separate unrelated config fields * fix: 🐛 correctly configre setup core * feat: 🎸 navigate to correct index pattern * chore: 🤖 fix type check errors * fix: 🐛 make index pattern select full width * fix: 🐛 add getHref support * feat: 🎸 add example plugin ability to X-Pack * refactor: 💡 move Discover drilldown example to X-Pack * feat: 🎸 add dashboard-to-url drilldown example * feat: 🎸 add new tab support for URL drilldown * feat: 🎸 add "hello world" drilldown example * docs: ✏️ add README * feat: 🎸 add getHref support * chore: 🤖 cleanup after moving examples to X-Pack * docs: ✏️ add to README.md info on how to find drilldowns * feat: 🎸 store events in .enhancements field * docs: ✏️ add comment to range trigger title * refactor: 💡 move Configurable interface into kibana_utils * chore: 🤖 simplify internal component types * refactor: 💡 move registerDrilldwon() to advanced_ui_actions * test: 💍 update functional test data * merge * docs: ✏️ make drilldown enhancement comment more general * fix: 🐛 return public type from registerAction() call * docs: ✏️ add comment to value click trigger title field * docs: ✏️ improve comment * fix: 🐛 use second argument of CollectConfigProps interface * fix: 🐛 add workaround for Firefox rendering issue See: #61219 * chore: 🤖 delete unused file * fix: 🐛 import type from new location * style: 💄 make generic type variable name sconsistent * fix: 🐛 show "Create drilldown" only on dashboard * test: 💍 add extra unit test for root embeddable type * docs: ✏️ update generated docs * chore: 🤖 add example warnings to sample drilldowns * docs: ✏️ add links to example warnings * feat: 🎸 add URL drilldown validation and https:// prefixing * fix: 🐛 disable drilldowns for lens * refactor: 💡 remove PlaceContext from DrilldownDefinition * fix: 🐛 fix type check error * feat: 🎸 show warning message if embeddable not provided Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Matt Kime <matt@mattki.me> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com> Co-authored-by: ppisljar <peter.pisljar@gmail.com>

@mdefazio

* Add drilldown wizard components * Dynamic actions (#58216) * feat: 🎸 add DynamicAction and FactoryAction types * feat: 🎸 add Mutable<T> type to @kbn/utility-types * feat: 🎸 add ActionInternal and ActionContract * chore: 🤖 remove unused file * feat: 🎸 improve action interfaces * docs: ✏️ add JSDocs * feat: 🎸 simplify ui_actions interfaces * fix: 🐛 fix TypeScript types * feat: 🎸 add AbstractPresentable interface * feat: 🎸 add AbstractConfigurable interface * feat: 🎸 use AbstractPresentable in ActionInternal * test: 💍 fix ui_actions Jest tests * feat: 🎸 add state container to action * perf: ⚡️ convert MenuItem to React component on Action instance * refactor: 💡 rename AbsractPresentable -> Presentable * refactor: 💡 rename AbstractConfigurable -> Configurable * feat: 🎸 add Storybook to ui_actions * feat: 🎸 add <ErrorConfigureAction> component * feat: 🎸 improve <ConfigureAction> component * chore: 🤖 use .story file extension prefix for Storybook * feat: 🎸 improve <ErrorConfigureAction> component * feat: 🎸 show error if dynamic action has CollectConfig missing * feat: 🎸 render sample action configuration component * feat: 🎸 connect action config to <ConfigureAction> * feat: 🎸 improve <ConfigureAction> stories * test: 💍 add ActionInternal serialize/deserialize tests * feat: 🎸 add ActionContract * feat: 🎸 split action Context into Execution and Presentation * fix: 🐛 fix TypeScript error * refactor: 💡 extract state container hooks to module scope * docs: ✏️ fix typos * chore: 🤖 remove Mutable<t> type * test: 💍 don't cast to any getActions() function * style: 💄 avoid using unnecessary types * chore: 🤖 address PR review comments * chore: 🤖 rename ActionContext generic * chore: 🤖 remove order from state container * chore: 🤖 remove deprecation notice on getHref * test: 💍 fix tests after order field change * remove comments Co-authored-by: Matt Kime <matt@mattki.me> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Drilldown context menu (#59638) * fix: 🐛 fix TypeScript error * feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger * fix: 🐛 correctly order context menu items * fix: 🐛 set correct order on drilldown flyout actions * fix: 🐛 clean up context menu building functions * feat: 🎸 add context menu separator action * Add basic ActionFactoryService. Pass data from it into components instead of mocks * Dashboard x pack (#59653) * feat: 🎸 add dashboard_enhanced plugin to x-pack * feat: 🎸 improve context menu separator * feat: 🎸 move drilldown flyout actions to dashboard_enhanced * fix: 🐛 fix exports from ui_actions plugin * feat: 🎸 "implement" registerDrilldown() method * fix ConfigurableBaseConfig type * Implement connected flyout_manage_drilldowns component * Simplify connected flyout manage drilldowns component. Remove intermediate component * clean up data-testid workaround in new components * Connect welcome message to storage Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped. * require `context` in Presentable. drill context down through wizard components * Drilldown factory (#59823) * refactor: 💡 import storage interface from ui_actions plugin * refactor: 💡 make actions not-dynamic * feat: 🎸 fix TypeScript errors, reshuffle types and code * fix: 🐛 fix more TypeScript errors * fix: 🐛 fix TypeScript import error * Drilldown registration (#59834) * feat: 🎸 improve drilldown registration method * fix: 🐛 set up translations for dashboard_enhanced plugin * Drilldown events 3 (#59854) * feat: 🎸 add serialize/unserialize to action * feat: 🎸 pass in uiActions service into Embeddable * feat: 🎸 merge ui_actions oss and basic plugins * refactor: 💡 move action factory registry to OSS * fix: 🐛 fix TypeScript errors * Drilldown events 4 (#59876) * feat: 🎸 mock sample drilldown execute methods * feat: 🎸 add .dynamicActions manager to Embeddable * feat: 🎸 add first version of dynamic action manager * Drilldown events 5 (#59885) * feat: 🎸 display drilldowns in context menu only on one embed * feat: 🎸 clear dynamic actions from registry when embed unloads * fix: 🐛 fix OSS TypeScript errors * basic integration of components with dynamicActionManager * fix: 🐛 don't overwrite explicitInput with combined input (#59938) * display drilldown count in embeddable edit mode * display drilldown count in embeddable edit mode * improve wizard components. more tests. * partial progress, dashboard drilldowns (#59977) * partial progress, dashboard drilldowns * partial progress, dashboard drilldowns * feat: 🎸 improve dashboard drilldown setup * feat: 🎸 wire in services into dashboard drilldown * chore: 🤖 add Storybook to dashboard_enhanced * feat: 🎸 create presentational <DashboardDrilldownConfig> * test: 💍 add <DashboardDrilldownConfig> stories * test: 💍 use presentation dashboar config component * feat: 🎸 wire in services into React component * docs: ✏️ add README to /components folder * feat: 🎸 increase importance of Dashboard drilldown * feat: 🎸 improve icon definition in drilldowns * chore: 🤖 remove unnecessary comment * chore: 🤖 add todos Co-authored-by: streamich <streamich@gmail.com> * Manage drilldowns toasts. Add basic error handling. * support order in action factory selector * fix column order in manage drilldowns list * remove accidental debug info * bunch of nit ui fixes * Drilldowns reactive action manager (#60099) * feat: 🎸 improve isConfigValid return type * feat: 🎸 make DynamicActionManager reactive * docs: ✏️ add JSDocs to public mehtods of DynamicActionManager * feat: 🎸 make panel top-right corner number badge reactive * fix: 🐛 correctly await for .deleteEvents() * Drilldowns various 2 (#60103) * chore: 🤖 address review comments * test: 💍 fix embeddable_panel.test.tsx tests * chore: 🤖 clean up ActionInternal * chore: 🤖 make isConfigValid a simple predicate * chore: 🤖 fix TypeScript type errors * test: 💍 stub DynamicActionManager tests (#60104) * Drilldowns review 1 (#60139) * refactor: 💡 improve generic types * fix: 🐛 don't overwrite icon * fix: 🐛 fix x-pack TypeScript errors * fix: 🐛 fix TypeScript error * fix: 🐛 correct merge * Drilldowns various 4 (#60264) * feat: 🎸 hide "Create drilldown" from context menu when needed * style: 💄 remove AnyDrilldown type * feat: 🎸 add drilldown factory context * chore: 🤖 remove sample drilldown * fix: 🐛 increase spacing between action factory picker * workaround issue with closing flyout when navigating away Adds overlay just like other flyouts which makes this defect harder to bump in * fix react key issue in action_wizard * don’t open 2 flyouts * fix action order #60138 * Drilldowns reload stored (#60336) * style: 💄 don't use double equals __ * feat: 🎸 add reload$ to ActionStorage interface * feat: 🎸 add reload$ to embeddable event storage * feat: 🎸 add storage syncing to DynamicActionManager * refactor: 💡 use state from DynamicActionManager in React * fix: 🐛 add check for manager being stopped * Drilldowns triggers (#60339) * feat: 🎸 make use of supportedTriggers() * feat: 🎸 pass in context to configuration component * feat: 🎸 augment factory context * fix: 🐛 stop infinite re-rendering * Drilldowns multitrigger (#60357) * feat: 🎸 add support for multiple triggers * feat: 🎸 enable Drilldowns for TSVB Although TSVB brushing event is now broken on master, KibanaApp plans to fix it in 7.7 * "Create drilldown" flyout - design cleanup (#60309) * create drilldown flyout cleanup * remove border from selectedActionFactoryContainer * adjust callout in DrilldownHello * update form labels * remove unused file * fix type error Co-authored-by: Anton Dosov <anton.dosov@elastic.co> * basic unit tests for flyout_create_drildown action * Drilldowns finalize (#60371) * fix: 🐛 align flyout content to left side * fix: 🐛 move context menu item number 1px lower * fix: 🐛 move flyout back nav chevron up * fix: 🐛 fix type check after refactor * basic unit tests for drilldown actions * Drilldowns finalize 2 (#60510) * test: 💍 fix test mock * chore: 🤖 remove unused UiActionsService methods * refactor: 💡 cleanup UiActionsService action registration * fix: 🐛 add missing functionality after refactor * test: 💍 add action factory tests * test: 💍 add DynamicActionManager tests * feat: 🎸 capture error if it happens during initial load * fix: 🐛 register correctly CSV action * feat: 🎸 don't show "OPTIONS" title on drilldown context menus * feat: 🎸 add server-side for x-pack dashboard plugin * feat: 🎸 disable Drilldowns for TSVB * feat: 🎸 enable drilldowns on kibana.yml feature flag * feat: 🎸 add feature flag comment to kibana.yml * feat: 🎸 remove places from drilldown interface * refactor: 💡 remove place in factory context * chore: 🤖 remove doExecute * remove not needed now error_configure_action component * remove workaround for storybook * feat: 🎸 improve DrilldownDefinition interface * style: 💄 replace any by unknown * chore: 🤖 remove any * chore: 🤖 make isConfigValid return type a boolean * refactor: 💡 move getDisplayName to factory, remove deprecated * style: 💄 remove any * feat: 🎸 improve ActionFactoryDefinition * refactor: 💡 change visualize_embeddable params * feat: 🎸 add dashboard dependency to dashboard_enhanced * style: 💄 rename drilldown plugin life-cycle contracts * refactor: 💡 do naming adjustments for dashboard drilldown * fix: 🐛 fix Type error * fix: 🐛 fix TypeScript type errors * test: 💍 fix test after refactor * refactor: 💡 rename context -> placeContext in React component * chore: 🤖 remove setting from kibana.yml * refactor: 💡 change return type of getAction as per review * remove custom css per review * refactor: 💡 rename drilldownCount to eventCount * style: 💄 remove any * refactor: 💡 change how uiActions are passed to vis embeddable * style: 💄 remove unused import * fix: 🐛 pass in uiActions to visualize_embeddable * fix: 🐛 correctly register action * fix: 🐛 fix type error * chore: 🤖 remove unused translations * Dynamic actions to xpack (#62647) * feat: 🎸 set up sample action factory provider * feat: 🎸 create dashboard_enhanced plugin * feat: 🎸 add EnhancedEmbeddable interface * refactor: 💡 move DynamicActionManager to x-pack * feat: 🎸 connect dynamic action manager to embeddable life-cycle * test: 💍 fix Jest tests after refactor * fix: 🐛 fix type error Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * refactor: 💡 move action factories to x-pack (#63190) * refactor: 💡 move action factories to x-pack * fix: 🐛 use correct plugin embeddable deps * test: 💍 fix Jest test after refactor * chore: 🤖 remove kibana.yml flag (#62441) * Panel top right (#63466) * feat: 🎸 add PANEL_NOTIFICATION_TRIGGER * feat: 🎸 add PanelNotificationsAction action * test: 💍 add PanelNotificationsAction unit tests * refactor: 💡 revert addTriggerAction() change * style: 💄 remove unused import * fix: 🐛 fix typecheck errors after merge * support getHref in drilldowns (#63727) * chore: 🤖 remove ui_actions storybook config * update docs * fix ts * fix: 🐛 fix broken merge * [Drilldowns] Dashboard to dashboard drilldown (#63108) * partial progress on async loading / searching of dashboard titles * feat: 🎸 make combobox full width * filtering combobox polish * storybook fix * implement navigating to dashboard, seems like a type problem * try navToApp * filter out current dashboard * rough draft linking to a dashboard * remove note * typefix * fix navigation from dashboard to dashboard except for back button - that would be addressed separatly * partial progress getting filters from action data * fix issue with getIndexPatterns undefined we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull * fix filter / time passing into url * typefix * dashboard to dashboard drilldown functional test and back button fix * documentation update * chore clean-ups fix type * basic unit test for dashboard drilldown * remove test todos decided to skip those tests because not clear how to test due to EuiCombobox is using react-virtualized and options list is not rendered in jsdom env * remove config * improve back button with filter comparison tweak * dashboard filters/date option off by default * revert change to config/kibana.yml * remove unneeded comments * use default time range as appropriate * fix type, add filter icon, add text * fix test * change how time range is restored and improve back button for drilldowns * resolve conflicts * fix async compile issue * remove redundant test * wip * wip * fix * temp skip tests * fix * handle missing dashboard edge case * fix api * refactor action filter creation utils * updating * updating docs * improve * fix storybook * post merge fixes * fix payload emitted in brush event * properly export createRange action * improve tests * add test * post merge fixes * improve * fix * improve * fix build * wip getHref support * implement getHref() * give proper name to a story * use sync start services * update text * fix types * fix ts * fix docs * move clone below drilldowns (near replace) * remove redundant comments * refactor action filter creation utils * updating * updating docs * fix payload emitted in brush event * properly export createRange action * some more updates * fixing types * ... * inline EventData * fix typescript in lens and update docs * improve filters types * docs * merge * @mdefazio review * adjust actions order * docs * @stacey-gammon review Co-authored-by: Matt Kime <matt@mattki.me> Co-authored-by: streamich <streamich@gmail.com> Co-authored-by: ppisljar <peter.pisljar@gmail.com> * fix docs * nit fixes * chore: 🤖 remove uiActions from Embeddable dependencies * chore: 🤖 don't export ActionInternal from ui_actions * test: 💍 remove uiActions deps in x-pack test mocks * chore: 🤖 cleanup ui_actions types * docs: ✏️ add JSDoc comment to addTriggerAction() * docs: ✏️ regenerate docs * Drilldown demo 2 (#64300) * chore: 🤖 add example of Discover drilldown to sample plugin * fix: 🐛 show drilldowns with higher "order" first * feat: 🎸 add createStartServicesGetter() to /public kibana_util * feat: 🎸 load index patterns in Discover drilldown * feat: 🎸 add toggle for index pattern selection * feat: 🎸 add spacer to separate unrelated config fields * fix: 🐛 correctly configre setup core * feat: 🎸 navigate to correct index pattern * chore: 🤖 fix type check errors * fix: 🐛 make index pattern select full width * fix: 🐛 add getHref support * feat: 🎸 add example plugin ability to X-Pack * refactor: 💡 move Discover drilldown example to X-Pack * feat: 🎸 add dashboard-to-url drilldown example * feat: 🎸 add new tab support for URL drilldown * feat: 🎸 add "hello world" drilldown example * docs: ✏️ add README * feat: 🎸 add getHref support * chore: 🤖 cleanup after moving examples to X-Pack * docs: ✏️ add to README.md info on how to find drilldowns * feat: 🎸 store events in .enhancements field * docs: ✏️ add comment to range trigger title * refactor: 💡 move Configurable interface into kibana_utils * chore: 🤖 simplify internal component types * refactor: 💡 move registerDrilldwon() to advanced_ui_actions * test: 💍 update functional test data * merge * docs: ✏️ make drilldown enhancement comment more general * fix: 🐛 return public type from registerAction() call * docs: ✏️ add comment to value click trigger title field * docs: ✏️ improve comment * fix: 🐛 use second argument of CollectConfigProps interface * fix: 🐛 add workaround for Firefox rendering issue See: #61219 * chore: 🤖 delete unused file * fix: 🐛 import type from new location * style: 💄 make generic type variable name sconsistent * fix: 🐛 show "Create drilldown" only on dashboard * test: 💍 add extra unit test for root embeddable type * docs: ✏️ update generated docs * chore: 🤖 add example warnings to sample drilldowns * docs: ✏️ add links to example warnings * feat: 🎸 add URL drilldown validation and https:// prefixing * fix: 🐛 disable drilldowns for lens * refactor: 💡 remove PlaceContext from DrilldownDefinition * fix: 🐛 fix type check error * feat: 🎸 show warning message if embeddable not provided Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Matt Kime <matt@mattki.me> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com> Co-authored-by: ppisljar <peter.pisljar@gmail.com> # Conflicts: # .github/CODEOWNERS

mattkime and others added 30 commits March 12, 2020 23:57

partial progress on async loading / searching of dashboard titles

813a896

feat: 🎸 make combobox full width

65ff148

filtering combobox polish

d46fcf0

Merge branch 'drilldowns_load_dashboard_list' of github.com:mattkime/…

6e11bc2

…kibana into drilldowns_load_dashboard_list

storybook fix

699d853

implement navigating to dashboard, seems like a type problem

d3ac7ad

Merge branch 'drilldowns' into drilldowns_load_dashboard_list

a5ee274

try navToApp

4369399

Merge branch 'drilldowns' into drilldowns_load_dashboard_list

94b08ae

Merge remote-tracking branch 'upstream/drilldowns' into drilldowns_lo…

86f9768

…ad_dashboard_list

filter out current dashboard

a276b96

Merge branch 'drilldowns' into drilldowns_load_dashboard_list

a112732

rough draft linking to a dashboard

3b39dcd

remove note

0bbf360

typefix

636d9ab

fix navigation from dashboard to dashboard

6ea19aa

except for back button - that would be addressed separatly

Merge branch 'drilldowns' into drilldowns_load_dashboard_list

0178ff5

partial progress getting filters from action data

a431e86

fix issue with getIndexPatterns undefined

4217b18

we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull

fix filter / time passing into url

177822f

Merge branch 'drilldowns' into drilldowns_load_dashboard_list

8bcbc1b

typefix

f7b7add

Merge branch 'drilldowns_load_dashboard_list' of github.com:mattkime/…

346dc40

…kibana into drilldowns_load_dashboard_list

dashboard to dashboard drilldown functional test and back button fix

bd7a91c

documentation update

5ea7818

Merge branch 'drilldowns' into drilldowns_load_dashboard_list

8297b55

Merge branch 'drilldowns' into drilldowns_load_dashboard_list

feccdfc

Merge branch 'drilldowns' of github.com:elastic/kibana into dev/drill…

29e885c

…downs/drilldowns_load_dashboard_list

chore clean-ups

100c4f0

fix type

basic unit test for dashboard drilldown

340fd89

Dosant requested review from mattkime, mdefazio and andreadelrio April 22, 2020 09:26

Dosant added 2 commits April 22, 2020 13:25

merge

b83ee56

@mdefazio review

8566cbc

Dosant commented Apr 22, 2020

View reviewed changes

mdefazio approved these changes Apr 22, 2020

View reviewed changes

adjust actions order

218d66f

Dosant commented Apr 22, 2020

View reviewed changes

andreadelrio approved these changes Apr 23, 2020

View reviewed changes

streamich approved these changes Apr 23, 2020

View reviewed changes

Dosant added 2 commits April 23, 2020 14:03

Merge branch 'drilldowns' of github.com:elastic/kibana into dev/drill…

0785dc6

…downs/drilldowns_load_dashboard_list # Conflicts: # src/plugins/data/public/public.api.md

docs

0997398

streamich mentioned this pull request Apr 23, 2020

Dashboard-to-XYZ drilldowns #61785

Closed

6 tasks

stacey-gammon approved these changes Apr 23, 2020

View reviewed changes

@stacey-gammon review

8ec37f5

Dosant merged commit 02524f1 into elastic:drilldowns Apr 24, 2020

This was referenced Apr 28, 2020

[Drilldowns] import dashboard url generator from plugin contract #64628

Merged

[Drilldowns] dashboard url param to merge filters #64633

Closed

[Drilldowns] Dashboard url generator to preserve saved filters from destination dashboard #64767

Merged

streamich mentioned this pull request Apr 30, 2020

Drilldowns #61219

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Drilldowns] Dashboard to dashboard drilldown #63108

[Drilldowns] Dashboard to dashboard drilldown #63108

Dosant commented Apr 9, 2020 •

edited

Loading

Dosant Apr 22, 2020 •

edited

Loading

mdefazio Apr 22, 2020

mdefazio commented Apr 22, 2020

Dosant Apr 22, 2020

andreadelrio left a comment

streamich left a comment

stacey-gammon left a comment

stacey-gammon Apr 23, 2020

Dosant Apr 24, 2020

stacey-gammon Apr 23, 2020

stacey-gammon Apr 23, 2020

Dosant Apr 24, 2020

stacey-gammon Apr 23, 2020

Dosant Apr 24, 2020 •

edited

Loading

stacey-gammon Apr 24, 2020

Dosant Apr 27, 2020

stacey-gammon Apr 27, 2020

lukeelmers Apr 27, 2020

stacey-gammon Apr 27, 2020

Dosant Apr 28, 2020

stacey-gammon Apr 28, 2020

Dosant Apr 29, 2020 •

edited

Loading

stacey-gammon Apr 23, 2020

Dosant Apr 24, 2020 •

edited

Loading

stacey-gammon Apr 24, 2020

Dosant Apr 28, 2020

stacey-gammon Apr 23, 2020

Dosant Apr 24, 2020

kibanamachine commented Apr 24, 2020

streamich commented Apr 27, 2020

Dosant commented Apr 27, 2020

[Drilldowns] Dashboard to dashboard drilldown #63108

[Drilldowns] Dashboard to dashboard drilldown #63108

Conversation

Dosant commented Apr 9, 2020 • edited Loading

Summary

Checklist

For maintainers

Dosant Apr 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdefazio commented Apr 22, 2020

Choose a reason for hiding this comment

andreadelrio left a comment

Choose a reason for hiding this comment

streamich left a comment

Choose a reason for hiding this comment

stacey-gammon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dosant Apr 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dosant Apr 29, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dosant Apr 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibanamachine commented Apr 24, 2020

💚 Build Succeeded

History

streamich commented Apr 27, 2020

Dosant commented Apr 27, 2020

Dosant commented Apr 9, 2020 •

edited

Loading

Dosant Apr 22, 2020 •

edited

Loading

Dosant Apr 24, 2020 •

edited

Loading

Dosant Apr 29, 2020 •

edited

Loading

Dosant Apr 24, 2020 •

edited

Loading