-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Enterprise Search Kibana plugin #66922
New Enterprise Search Kibana plugin #66922
Commits on Jul 8, 2020
-
Initial App Search in Kibana plugin work
- Initializes a new platform plugin that ships out of the box w/ x-pack - Contains a very basic front-end that shows AS engines, error states, or a Setup Guide - Contains a very basic server that remotely calls the AS internal engines API and returns results
Configuration menu - View commit details
-
Copy full SHA for c107ccb - Browse repository at this point
Copy the full SHA c107ccbView commit details -
Update URL casing to match Kibana best practices
- URL casing appears to be snake_casing, but kibana.json casing appears to be camelCase
Configuration menu - View commit details
-
Copy full SHA for 7f47c8a - Browse repository at this point
Copy the full SHA 7f47c8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad1f754 - Browse repository at this point
Copy the full SHA ad1f754View commit details -
Add custom App Search in Kibana logo
- I haven't had much success in surfacing a SVG file via a server-side endpoint/URL, but then I realized EuiIcon supports passing in a ReactElement directly. Woo!
Configuration menu - View commit details
-
Copy full SHA for 852b9e6 - Browse repository at this point
Copy the full SHA 852b9e6View commit details -
Fix appSearch.host config setting to be optional
- instead of crashing folks on load
Configuration menu - View commit details
-
Copy full SHA for 68a4b10 - Browse repository at this point
Copy the full SHA 68a4b10View commit details -
Rename plugin to Enterprise Search
- per product decision, URL should be enterprise_search/app_search and Workplace Search should also eventually live here - reorganize folder structure in anticipation for another workplace_search plugin/codebase living alongside app_search - rename app.tsx/main.tsx to a standard top-level index.tsx (which will contain top-level routes/state) - rename AS->ES files/vars where applicable - TODO: React Router
Configuration menu - View commit details
-
Copy full SHA for fe6eac1 - Browse repository at this point
Copy the full SHA fe6eac1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c79af1a - Browse repository at this point
Copy the full SHA c79af1aView commit details -
Convert showSetupGuide action/flag to a React Router link
- remove showSetupGuide flag - add a new shared helper component for combining EuiButton/EuiLink with React Router behavior (https://github.com/elastic/eui/blob/master/wiki/react-router.md#react-router-51)
Configuration menu - View commit details
-
Copy full SHA for cbae563 - Browse repository at this point
Copy the full SHA cbae563View commit details -
Implement Kibana Chrome breadcrumbs
- create shared helper (WS will presumably also want this) for generating EUI breadcrumb objects with React Router links+click behavior - create React component that calls chrome.setBreadcrumbs on page mount - clean up type definitions - move app-wide props to IAppSearchProps and update most pages/views to simply import it instead of calling their own definitions
Configuration menu - View commit details
-
Copy full SHA for 0e7fd50 - Browse repository at this point
Copy the full SHA 0e7fd50View commit details -
* Added unit test for server * PR Feedback
Configuration menu - View commit details
-
Copy full SHA for b3c564e - Browse repository at this point
Copy the full SHA b3c564eView commit details -
Refactor top-level Kibana props to a global context state
- rather them passing them around verbosely as props, the components that need them should be able to call the useContext hook + Remove IAppSearchProps in favor of IKibanaContext + Also rename `appSearchUrl` to `enterpriseSearchUrl`, since this context will contained shared/Kibana-wide values/actions useful to both AS and WS
Configuration menu - View commit details
-
Copy full SHA for 0c083e1 - Browse repository at this point
Copy the full SHA 0c083e1View commit details -
Added unit tests for public (#4)
* application.test.ts * Added Unit Test for EngineOverviewHeader * Added Unit Test for generate_breadcrumbs * Added Unit Test for set_breadcrumb.tsx * Added a unit test for link_events - Also changed link_events.tsx to link_events.ts since it's just TS, no React - Modified letBrowserHandleEvent so it will still return a false boolean when target is blank * Betterize these tests Co-Authored-By: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1719a9d - Browse repository at this point
Copy the full SHA 1719a9dView commit details -
Add UI telemetry tracking to AS in Kibana (#5)
* Set up Telemetry usageCollection, savedObjects, route, & shared helper - The Kibana UsageCollection plugin handles collecting our telemetry UI data (views, clicks, errors, etc.) and pushing it to elastic's telemetry servers - That data is stored in incremented in Kibana's savedObjects lib/plugin (as well as mapped) - When an end-user hits a certain view or action, the shared helper will ping the app search telemetry route which increments the savedObject store * Update client-side views/links to new shared telemetry helper * Write tests for new telemetry files
Configuration menu - View commit details
-
Copy full SHA for c6393ed - Browse repository at this point
Copy the full SHA c6393edView commit details -
Implement remaining unit tests (#7)
* Write tests for React Router+EUI helper components * Update generate_breadcrumbs test - add test suite for generateBreadcrumb() itself (in order to cover a missing branch) - minor lint fixes - remove unnecessary import from set_breadcrumbs test * Write test for get_username util + update test to return a more consistent falsey value (null) * Add test for SetupGuide * [Refactor] Pull out various Kibana context mocks into separate files - I'm creating a reusable useContext mock for shallow()ed enzyme components + add more documentation comments + examples * Write tests for empty state components + test new usecontext shallow mock * Empty state components: Add extra getUserName branch test * Write test for app search index/routes * Write tests for engine overview table + fix bonus bug * Write Engine Overview tests + Update EngineOverview logic to account for issues found during tests :) - Move http to async/await syntax instead of promise syntax (works better with existing HttpServiceMock jest.fn()s) - hasValidData wasn't strict enough in type checking/object nest checking and was causing the app itself to crash (no bueno) * Refactor EngineOverviewHeader test to use shallow + to full coverage - missed adding this test during telemetry work - switching to shallow and beforeAll reduces the test time from 5s to 4s! * [Refactor] Pull out React Router history mocks into a test util helper + minor refactors/updates * Add small tests to increase branch coverage - mostly testing fallbacks or removing fallbacks in favor of strict type interface - these are slightly obsessive so I'd also be fine ditching them if they aren't terribly valuable
Configuration menu - View commit details
-
Copy full SHA for c8e3d99 - Browse repository at this point
Copy the full SHA c8e3d99View commit details -
Address larger tech debt/TODOs (#8)
* Fix optional chaining TODO - turns out my local Prettier wasn't up to date, completely my bad * Fix constants TODO - adds a common folder/architecture for others to use in the future * Remove TODO for eslint-disable-line and specify lint rule being skipped - hopefully that's OK for review, I can't think of any other way to sanely do this without re-architecting the entire file or DDoSing our API * Add server-side logging to route dependencies + add basic example of error catching/logging to Telemetry route + [extra] refactor mockResponseFactory name to something slightly easier to read * Move more Engines Overview API logic/logging to server-side - handle data validation in the server-side - wrap server-side API in a try/catch to account for fetch issues - more correctly return 2xx/4xx statuses and more correctly deal with those responses in the front-end - Add server info/error/debug logs (addresses TODO) - Update tests + minor refactors/cleanup - remove expectResponseToBe200With helper (since we're now returning multiple response types) and instead make mockResponse var name more readable - one-line header auth - update tests with example error logs - update schema validation for `type` to be an enum of `indexed`/`meta` (more accurately reflecting API)
Configuration menu - View commit details
-
Copy full SHA for a45d65e - Browse repository at this point
Copy the full SHA a45d65eView commit details -
Per telemetry team feedback, rename usageCollection telemetry mapping…
… name to simpler 'app_search' - since their mapping already nests under 'kibana.plugins' - note: I left the savedObjects name with the '_telemetry' suffix, as there very well may be a use case for top-level generic 'app_search' saved objects
Configuration menu - View commit details
-
Copy full SHA for 8eee7fd - Browse repository at this point
Copy the full SHA 8eee7fdView commit details -
Update Setup Guide installation instructions (#9)
Co-authored-by: Chris Cressman <chris@chriscressman.com>
Configuration menu - View commit details
-
Copy full SHA for 75cfd89 - Browse repository at this point
Copy the full SHA 75cfd89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90e8aae - Browse repository at this point
Copy the full SHA 90e8aaeView commit details -
[Refactor] Rename public/test_utils to public/__mocks__
- to better follow/use jest setups and for .mock.ts suffixes
Configuration menu - View commit details
-
Copy full SHA for f987781 - Browse repository at this point
Copy the full SHA f987781View commit details -
Add platinum licensing check to Meta Engines table/call (#11)
* Licensing plugin setup * Add LicensingContext setup * Update EngineOverview to not hit meta engines API on platinum license * Add Jest test helpers for future shallow/context use
Configuration menu - View commit details
-
Copy full SHA for 7883a23 - Browse repository at this point
Copy the full SHA 7883a23View commit details -
Update plugin to use new Kibana nav + URL update (#12)
* Update new nav categories to add Enterprise Search + update plugin to use new category - per @johnbarrierwilson and Matt Riley, Enterprise Search should be under Kibana and above Observability - Run `node scripts/check_published_api_changes.js --accept` since this new category affects public API * [URL UPDATE] Change '/app/enterprise_search/app_search' to '/app/app_search' - This needs to be done because App Search and Workplace search *have* to be registered as separate plugins to have 2 distinct nav links - Currently Kibana doesn't support nested app names (see: elastic#59190) but potentially will in the future - To support this change, we need to update applications/index.tsx to NOT handle '/app/enterprise_search' level routing, but instead accept an async imported app component (e.g. AppSearch, WorkplaceSearch). - AppSearch should now treat its router as root '/' instead of '/app_search' - (Addl) Per Josh Dover's recommendation, switch to `<Router history={params.history}>` from `<BrowserRouter basename={params.appBasePath}>` since they're deprecating appBasePath * Update breadcrumbs helper to account for new URLs - Remove path for Enterprise Search breadcrumb, since '/app/enterprise_search' will not link anywhere meaningful for the foreseeable future, so the Enterprise Search root should not go anywhere - Update App Search helper to go to root path, per new React Router setup Test changes: - Mock custom basepath for App Search tests - Swap enterpriseSearchBreadcrumbs and appSearchBreadcrumbs test order (since the latter overrides the default mock)
Configuration menu - View commit details
-
Copy full SHA for 4f83c5c - Browse repository at this point
Copy the full SHA 4f83c5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d9c1c4 - Browse repository at this point
Copy the full SHA 6d9c1c4View commit details -
Switch plugin URLs back to /app/enterprise_search/app_search
Now that elastic#66455 has been merged in 🎉
Configuration menu - View commit details
-
Copy full SHA for af15936 - Browse repository at this point
Copy the full SHA af15936View commit details -
Add i18n formatted messages / translations (#13)
* Add i18n provider and formatted/i18n translated messages * Update tests to account for new I18nProvider context + FormattedMessage components - Add new mountWithContext helper that provides all contexts+providers used in top-level app - Add new shallowWithIntl helper for shallow() components that dive into FormattedMessage * Format i18n dates and numbers + update some mock tests to not throw react-intl invalid date messages
Configuration menu - View commit details
-
Copy full SHA for 9f3645d - Browse repository at this point
Copy the full SHA 9f3645dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e886e0 - Browse repository at this point
Copy the full SHA 7e886e0View commit details -
* Fix Prettier linting issues * Escape App Search API endpoint URLs - per PR feedback - querystring should automatically encodeURIComponent / escape query param strings * Update server plugin.ts to use getStartServices() rather than storing local references from start() - Per feedback: https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md#applications - Note: savedObjects.registerType needs to be outside of getStartServices, or an error is thrown - Side update to registerTelemetryUsageCollector to simplify args - Update/fix tests to account for changes
Configuration menu - View commit details
-
Copy full SHA for 3454568 - Browse repository at this point
Copy the full SHA 3454568View commit details -
* Wired up basics for E2E testing * Added version with App Search * Updated naming * Switched configuration around * Added concept of 'fixtures' * Figured out how to log in as the enterprise_search user * Refactored to use an App Search service * Added some real tests * Added a README * Cleanup * More cleanup * Error handling + README updatre * Removed unnecessary files * Apply suggestions from code review Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_table.tsx Co-authored-by: Constance <constancecchen@users.noreply.github.com> * PR feedback - updated README * Additional lint fixes Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for fc19404 - Browse repository at this point
Copy the full SHA fc19404View commit details -
Add README and CODEOWNERS (#15)
* Add plugin README and CODEOWNERS
Configuration menu - View commit details
-
Copy full SHA for 0cd9668 - Browse repository at this point
Copy the full SHA 0cd9668View commit details -
* Fix public mocks * Fix empty states types * Fix engine table component errors * Fix engine overview component errors * Fix setup guide component errors - SetBreadcrumbs will be fixed in a separate commit * Fix App Search index errors * Fix engine overview header component errors * Fix applications context index errors * Fix kibana breadcrumb helper errors * Fix license helper errors * ❗ Refactor React Router EUI link/button helpers - in order to fix typescript errors - this changes the component logic significantly to a react render prop, so that the Link and Button components can have different types - however, end behavior should still remain the same * Fix telemetry helper errors * Minor unused var cleanup in plugin files * Fix telemetry collector/savedobjects errors * Fix MockRouter type errors and add IRouteDependencies export - routes will use IRouteDependencies in the next few commits * Fix engines route errors * Fix telemetry route errors * Remove any type from source code - thanks to Scotty for the inspiration * Add eslint rules for Enterprise Search plugin - Add checks for type any, but only on non-test files - Disable react-hooks/exhaustive-deps, since we're already disabling it in a few files and other plugins also have it turned off * Cover uncovered lines in engines_table and telemetry tests
Configuration menu - View commit details
-
Copy full SHA for e366a4a - Browse repository at this point
Copy the full SHA e366a4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fbdcc61 - Browse repository at this point
Copy the full SHA fbdcc61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 931ed8d - Browse repository at this point
Copy the full SHA 931ed8dView commit details -
Feedback: Flatten nested CSS where possible
- Prefer setting CSS class overrides on individual EUI components, not on a top-level page + Change CSS class casing from kebab-case to camelCase to better match EUI/Kibana + Remove unnecessary .euiPageContentHeader margin-bottom override by changing the panelPaddingSize of euiPageContent + Decrease engine overview table padding on mobile
Configuration menu - View commit details
-
Copy full SHA for 520408b - Browse repository at this point
Copy the full SHA 520408bView commit details -
Refactor out components shared with Workplace Search (#18)
* Move getUserName helper to shared - in preparation for Workplace Search plugin also using this helper * Move Setup Guide layout to a shared component * Setup Guide: add extra props for standard/native auth links Note: It's possible this commit may be unnecessary if we can publish shared Enterprise Search security mode docs
Configuration menu - View commit details
-
Copy full SHA for bef0ef5 - Browse repository at this point
Copy the full SHA bef0ef5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 176313e - Browse repository at this point
Copy the full SHA 176313eView commit details -
Address various telemetry issues
- saved objects: removing indexing per elastic#43673 - add schema and generate json per elastic#64942 - move definitions over to collectors since saved objects is mostly empty at this point, and schema throws an error when it imports an obj instead of being defined inline - istanbul ignore saved_objects file since it doesn't have anything meaningful to test but was affecting code coverage
Configuration menu - View commit details
-
Copy full SHA for f920bd4 - Browse repository at this point
Copy the full SHA f920bd4View commit details -
Disable plugin access if a normal user does not have access to App Se…
…arch (#19) * Set up new server security dependency and configs * Set up access capabilities * Set up checkAccess helper/caller * Remove NoUserState component from the public UI - Since this is now being handled by checkAccess / normal users should never see the plugin at all if they don't have an account/access, the component is no longer needed * Update server routes to account for new changes - Remove login redirect catch from routes, since the access helper should now handle that for most users by disabling the plugin (superusers will see a generic cannot connect/error screen) - Refactor out new config values to a shared mock * Refactor Enterprise Search http call to hit/return new internal API endpoint + pull out the http call to a separate library for upcoming public URL work (so that other files can call it directly as well) * [Discussion] Increase timeout but add another warning timeout for slow servers - per recommendation/convo with Brandon * Register feature control * Remove no_as_account from UI telemetry - since we're no longer tracking that in the UI * Address PR feedback - isSuperUser check
Configuration menu - View commit details
-
Copy full SHA for 2a14b5d - Browse repository at this point
Copy the full SHA 2a14b5dView commit details -
Public URL support for Elastic Cloud (#21)
* Add server-side public URL route - Per feedback from Kibana platform team, it's not possible to pass info from server/ to public/ without a HTTP call :[ * Update MockRouter for routes without any payload/params * Add client-side helper for calling the new public URL API + API seems to return a URL a trailing slash, which we need to omit * Update public/plugin.ts to check and set a public URL - relies on this.hasCheckedPublicUrl to only make the call once per page load instead of on every page nav
Configuration menu - View commit details
-
Copy full SHA for b1bf08a - Browse repository at this point
Copy the full SHA b1bf08aView commit details -
Fix failing feature control tests
- Split up scenario cases as needed - Add plugin as an exception alongside ML & Monitoring
Configuration menu - View commit details
-
Copy full SHA for 0d0ca9c - Browse repository at this point
Copy the full SHA 0d0ca9cView commit details -
- version: kibana - copy edits - Sass vars - code cleanup
Configuration menu - View commit details
-
Copy full SHA for a74b5e6 - Browse repository at this point
Copy the full SHA a74b5e6View commit details -
Casing feedback: change all plugin registration IDs from snake_case t…
…o camelCase - note: current remainng snake_case exceptions are telemetry keys - file names and api endpoints are snake_case per conventions
Configuration menu - View commit details
-
Copy full SHA for 972adcf - Browse repository at this point
Copy the full SHA 972adcfView commit details -
- remove set - remove unnecessary capabilities registration - telemetry namespace agnostic
Configuration menu - View commit details
-
Copy full SHA for 9e52680 - Browse repository at this point
Copy the full SHA 9e52680View commit details -
Security feedback: add warn logging to telemetry collector
see elastic#66922 (comment) - add if statement - pass log dependency around (this is kinda medium, should maybe refactor) - update tests - move test file comment to the right file (was meant for telemetry route file)
Configuration menu - View commit details
-
Copy full SHA for 15a8b15 - Browse repository at this point
Copy the full SHA 15a8b15View commit details -
- Remove unnecessary ServerConfigType - Remove unnecessary uiCapabilities - Move registerTelemetryRoute / SavedObjectsServiceStart workaround - Remove unnecessary license optional chaining
Configuration menu - View commit details
-
Copy full SHA for 9c6acdd - Browse repository at this point
Copy the full SHA 9c6acddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b715b5 - Browse repository at this point
Copy the full SHA 3b715b5View commit details -
Fix telemetry API call returning 415 on Chrome
- I can't even?? I swear charset=utf-8 fixed the same error a few weeks ago
Configuration menu - View commit details
-
Copy full SHA for d72e988 - Browse repository at this point
Copy the full SHA d72e988View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6740f2 - Browse repository at this point
Copy the full SHA d6740f2View commit details -
Update Enterprise Search functional tests (without host) to run on CI
- Fix incorrect navigateToApp slug (hadn't realized this was a URL, not an ID) - Update without_host_configured tests to run without API key - Update README
Configuration menu - View commit details
-
Copy full SHA for f305f11 - Browse repository at this point
Copy the full SHA f305f11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fbde3a - Browse repository at this point
Copy the full SHA 2fbde3aView commit details
Commits on Jul 9, 2020
-
Address PR feedback from Pierre
- remove unnecessary authz? - remove unnecessary content-type json headers - add loggingSystemMock.collect(mockLogger).error assertion - reconstrcut new MockRouter on beforeEach for better sandboxing - fix incorrect describe()s -should be it() - pull out reusable mockDependencies helper (renamed/extended from mockConfig) for tests that don't particularly use config/log but still want to pass type definitions - Fix comment copy
Configuration menu - View commit details
-
Copy full SHA for 8ce4486 - Browse repository at this point
Copy the full SHA 8ce4486View commit details