Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Enterprise Search Kibana plugin #66922

Merged
merged 49 commits into from
Jul 9, 2020

Commits on Jul 8, 2020

  1. Initial App Search in Kibana plugin work

    - Initializes a new platform plugin that ships out of the box w/ x-pack
    - Contains a very basic front-end that shows AS engines, error states, or a Setup Guide
    - Contains a very basic server that remotely calls the AS internal engines API and returns results
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    c107ccb View commit details
    Browse the repository at this point in the history
  2. Update URL casing to match Kibana best practices

    - URL casing appears to be snake_casing, but kibana.json casing appears to be camelCase
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7f47c8a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad1f754 View commit details
    Browse the repository at this point in the history
  4. Add custom App Search in Kibana logo

    - I haven't had much success in surfacing a SVG file via a server-side endpoint/URL, but then I realized EuiIcon supports passing in a ReactElement directly. Woo!
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    852b9e6 View commit details
    Browse the repository at this point in the history
  5. Fix appSearch.host config setting to be optional

    - instead of crashing folks on load
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    68a4b10 View commit details
    Browse the repository at this point in the history
  6. Rename plugin to Enterprise Search

    - per product decision, URL should be enterprise_search/app_search and Workplace Search should also eventually live here
    - reorganize folder structure in anticipation for another workplace_search plugin/codebase living alongside app_search
    - rename app.tsx/main.tsx to a standard top-level index.tsx (which will contain top-level routes/state)
    - rename AS->ES files/vars where applicable
    - TODO: React Router
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    fe6eac1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c79af1a View commit details
    Browse the repository at this point in the history
  8. Convert showSetupGuide action/flag to a React Router link

    - remove showSetupGuide flag
    - add a new shared helper component for combining EuiButton/EuiLink with React Router behavior (https://github.com/elastic/eui/blob/master/wiki/react-router.md#react-router-51)
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    cbae563 View commit details
    Browse the repository at this point in the history
  9. Implement Kibana Chrome breadcrumbs

    - create shared helper (WS will presumably also want this) for generating EUI breadcrumb objects with React Router links+click behavior
    - create React component that calls chrome.setBreadcrumbs on page mount
    - clean up type definitions - move app-wide props to IAppSearchProps and update most pages/views to simply import it instead of calling their own definitions
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0e7fd50 View commit details
    Browse the repository at this point in the history
  10. Added server unit tests (#2)

    * Added unit test for server
    
    * PR Feedback
    JasonStoltz authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b3c564e View commit details
    Browse the repository at this point in the history
  11. Refactor top-level Kibana props to a global context state

    - rather them passing them around verbosely as props, the components that need them should be able to call the useContext hook
    
    + Remove IAppSearchProps in favor of IKibanaContext
    
    + Also rename `appSearchUrl` to `enterpriseSearchUrl`, since this context will contained shared/Kibana-wide values/actions useful to both AS and WS
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0c083e1 View commit details
    Browse the repository at this point in the history
  12. Added unit tests for public (#4)

    * application.test.ts
    
    * Added Unit Test for EngineOverviewHeader
    
    * Added Unit Test for generate_breadcrumbs
    
    * Added Unit Test for set_breadcrumb.tsx
    
    * Added a unit test for link_events
    
    - Also changed link_events.tsx to link_events.ts since it's just TS, no
    React
    - Modified letBrowserHandleEvent so it will still return a false
    boolean when target is blank
    
    * Betterize these tests
    
    Co-Authored-By: Constance <constancecchen@users.noreply.github.com>
    
    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    2 people authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    1719a9d View commit details
    Browse the repository at this point in the history
  13. Add UI telemetry tracking to AS in Kibana (#5)

    * Set up Telemetry usageCollection, savedObjects, route, & shared helper
    
    - The Kibana UsageCollection plugin handles collecting our telemetry UI data (views, clicks, errors, etc.) and pushing it to elastic's telemetry servers
    - That data is stored in incremented in Kibana's savedObjects lib/plugin (as well as mapped)
    - When an end-user hits a certain view or action, the shared helper will ping the app search telemetry route which increments the savedObject store
    
    * Update client-side views/links to new shared telemetry helper
    
    * Write tests for new telemetry files
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    c6393ed View commit details
    Browse the repository at this point in the history
  14. Implement remaining unit tests (#7)

    * Write tests for React Router+EUI helper components
    
    * Update generate_breadcrumbs test
    
    - add test suite for generateBreadcrumb() itself (in order to cover a missing branch)
    - minor lint fixes
    - remove unnecessary import from set_breadcrumbs test
    
    * Write test for get_username util
    
    + update test to return a more consistent falsey value (null)
    
    * Add test for SetupGuide
    
    * [Refactor] Pull out various Kibana context mocks into separate files
    
    - I'm creating a reusable useContext mock for shallow()ed enzyme components
    + add more documentation comments + examples
    
    * Write tests for empty state components
    
    + test new usecontext shallow mock
    
    * Empty state components: Add extra getUserName branch test
    
    * Write test for app search index/routes
    
    * Write tests for engine overview table
    
    + fix bonus bug
    
    * Write Engine Overview tests
    
    + Update EngineOverview logic to account for issues found during tests :)
      - Move http to async/await syntax instead of promise syntax (works better with existing HttpServiceMock jest.fn()s)
      - hasValidData wasn't strict enough in type checking/object nest checking and was causing the app itself to crash (no bueno)
    
    * Refactor EngineOverviewHeader test to use shallow + to full coverage
    
    - missed adding this test during telemetry work
    - switching to shallow and beforeAll reduces the test time from 5s to 4s!
    
    * [Refactor] Pull out React Router history mocks into a test util helper
    
    + minor refactors/updates
    
    * Add small tests to increase branch coverage
    
    - mostly testing fallbacks or removing fallbacks in favor of strict type interface
    - these are slightly obsessive so I'd also be fine ditching them if they aren't terribly valuable
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    c8e3d99 View commit details
    Browse the repository at this point in the history
  15. Address larger tech debt/TODOs (#8)

    * Fix optional chaining TODO
    
    - turns out my local Prettier wasn't up to date, completely my bad
    
    * Fix constants TODO
    
    - adds a common folder/architecture for others to use in the future
    
    * Remove TODO for eslint-disable-line and specify lint rule being skipped
    
    - hopefully that's OK for review, I can't think of any other way to sanely do this without re-architecting the entire file or DDoSing our API
    
    * Add server-side logging to route dependencies
    
    + add basic example of error catching/logging to Telemetry route
    + [extra] refactor mockResponseFactory name to something slightly easier to read
    
    * Move more Engines Overview API logic/logging to server-side
    
    - handle data validation in the server-side
    - wrap server-side API in a try/catch to account for fetch issues
    - more correctly return 2xx/4xx statuses and more correctly deal with those responses in the front-end
    - Add server info/error/debug logs (addresses TODO)
    - Update tests + minor refactors/cleanup
        - remove expectResponseToBe200With helper (since we're now returning multiple response types) and instead make mockResponse var name more readable
        - one-line header auth
        - update tests with example error logs
        - update schema validation for `type` to be an enum of `indexed`/`meta` (more accurately reflecting API)
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    a45d65e View commit details
    Browse the repository at this point in the history
  16. Per telemetry team feedback, rename usageCollection telemetry mapping…

    … name to simpler 'app_search'
    
    - since their mapping already nests under 'kibana.plugins'
    - note: I left the savedObjects name with the '_telemetry' suffix, as there very well may be a use case for top-level generic 'app_search' saved objects
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    8eee7fd View commit details
    Browse the repository at this point in the history
  17. Update Setup Guide installation instructions (#9)

    Co-authored-by: Chris Cressman <chris@chriscressman.com>
    2 people authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    75cfd89 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    90e8aae View commit details
    Browse the repository at this point in the history
  19. [Refactor] Rename public/test_utils to public/__mocks__

    - to better follow/use jest setups and for .mock.ts suffixes
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    f987781 View commit details
    Browse the repository at this point in the history
  20. Add platinum licensing check to Meta Engines table/call (#11)

    * Licensing plugin setup
    
    * Add LicensingContext setup
    
    * Update EngineOverview to not hit meta engines API on platinum license
    
    * Add Jest test helpers for future shallow/context use
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7883a23 View commit details
    Browse the repository at this point in the history
  21. Update plugin to use new Kibana nav + URL update (#12)

    * Update new nav categories to add Enterprise Search + update plugin to use new category
    
    - per @johnbarrierwilson and Matt Riley, Enterprise Search should be under Kibana and above Observability
    - Run `node scripts/check_published_api_changes.js --accept` since this new category affects public API
    
    * [URL UPDATE] Change '/app/enterprise_search/app_search' to '/app/app_search'
    
    - This needs to be done because App Search and Workplace search *have* to be registered as separate plugins to have 2 distinct nav links
    - Currently Kibana doesn't support nested app names (see: elastic#59190) but potentially will in the future
    
    - To support this change, we need to update applications/index.tsx to NOT handle '/app/enterprise_search' level routing, but instead accept an async imported app component (e.g. AppSearch, WorkplaceSearch).
    - AppSearch should now treat its router as root '/' instead of '/app_search'
    
    - (Addl) Per Josh Dover's recommendation, switch to `<Router history={params.history}>` from `<BrowserRouter basename={params.appBasePath}>` since they're deprecating appBasePath
    
    * Update breadcrumbs helper to account for new URLs
    
    - Remove path for Enterprise Search breadcrumb, since '/app/enterprise_search' will not link anywhere meaningful for the foreseeable future, so the Enterprise Search root should not go anywhere
    - Update App Search helper to go to root path, per new React Router setup
    
    Test changes:
    - Mock custom basepath for App Search tests
    - Swap enterpriseSearchBreadcrumbs and appSearchBreadcrumbs test order (since the latter overrides the default mock)
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    4f83c5c View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    6d9c1c4 View commit details
    Browse the repository at this point in the history
  23. Switch plugin URLs back to /app/enterprise_search/app_search

    Now that elastic#66455 has been merged in 🎉
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    af15936 View commit details
    Browse the repository at this point in the history
  24. Add i18n formatted messages / translations (#13)

    * Add i18n provider and formatted/i18n translated messages
    
    * Update tests to account for new I18nProvider context + FormattedMessage components
    
    - Add new mountWithContext helper that provides all contexts+providers used in top-level app
    - Add new shallowWithIntl helper for shallow() components that dive into FormattedMessage
    
    * Format i18n dates and numbers
    
    + update some mock tests to not throw react-intl invalid date messages
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    9f3645d View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    7e886e0 View commit details
    Browse the repository at this point in the history
  26. Address review feedback (#14)

    * Fix Prettier linting issues
    
    * Escape App Search API endpoint URLs
    
    - per PR feedback
    - querystring should automatically encodeURIComponent / escape query param strings
    
    * Update server plugin.ts to use getStartServices() rather than storing local references from start()
    
    - Per feedback: https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md#applications
    
    - Note: savedObjects.registerType needs to be outside of getStartServices, or an error is thrown
    
    - Side update to registerTelemetryUsageCollector to simplify args
    
    - Update/fix tests to account for changes
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    3454568 View commit details
    Browse the repository at this point in the history
  27. E2E testing (#6)

    * Wired up basics for E2E testing
    
    * Added version with App Search
    
    * Updated naming
    
    * Switched configuration around
    
    * Added concept of 'fixtures'
    
    * Figured out how to log in as the enterprise_search user
    
    * Refactored to use an App Search service
    
    * Added some real tests
    
    * Added a README
    
    * Cleanup
    
    * More cleanup
    
    * Error handling + README updatre
    
    * Removed unnecessary files
    
    * Apply suggestions from code review
    
    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    
    * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_table.tsx
    
    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    
    * PR feedback - updated README
    
    * Additional lint fixes
    
    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    2 people authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    fc19404 View commit details
    Browse the repository at this point in the history
  28. Add README and CODEOWNERS (#15)

    * Add plugin README and CODEOWNERS
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0cd9668 View commit details
    Browse the repository at this point in the history
  29. Fix Typescript errors (#16)

    * Fix public mocks
    
    * Fix empty states types
    
    * Fix engine table component errors
    
    * Fix engine overview component errors
    
    * Fix setup guide component errors
    
    - SetBreadcrumbs will be fixed in a separate commit
    
    * Fix App Search index errors
    
    * Fix engine overview header component errors
    
    * Fix applications context index errors
    
    * Fix kibana breadcrumb helper errors
    
    * Fix license helper errors
    
    * ❗ Refactor React Router EUI link/button helpers
    - in order to fix typescript errors
    
    - this changes the component logic significantly to a react render prop, so that the Link and Button components can have different types - however, end behavior should still remain the same
    
    * Fix telemetry helper errors
    
    * Minor unused var cleanup in plugin files
    
    * Fix telemetry collector/savedobjects errors
    
    * Fix MockRouter type errors and add IRouteDependencies export
    
    - routes will use IRouteDependencies in the next few commits
    
    * Fix engines route errors
    
    * Fix telemetry route errors
    
    * Remove any type from source code
    
    - thanks to Scotty for the inspiration
    
    * Add eslint rules for Enterprise Search plugin
    
    - Add checks for type any, but only on non-test files
    - Disable react-hooks/exhaustive-deps, since we're already disabling it in a few files and other plugins also have it turned off
    
    * Cover uncovered lines in engines_table and telemetry tests
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    e366a4a View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    fbdcc61 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    931ed8d View commit details
    Browse the repository at this point in the history
  32. Feedback: Flatten nested CSS where possible

    - Prefer setting CSS class overrides on individual EUI components, not on a top-level page
    
    + Change CSS class casing from kebab-case to camelCase to better match EUI/Kibana
    
    + Remove unnecessary .euiPageContentHeader margin-bottom override by changing the panelPaddingSize of euiPageContent
    
    + Decrease engine overview table padding on mobile
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    520408b View commit details
    Browse the repository at this point in the history
  33. Refactor out components shared with Workplace Search (#18)

    * Move getUserName helper to shared
    
    - in preparation for Workplace Search plugin also using this helper
    
    * Move Setup Guide layout to a shared component
    
    * Setup Guide: add extra props for standard/native auth links
    
    Note: It's possible this commit may be unnecessary if we can publish shared Enterprise Search security mode docs
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    bef0ef5 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    176313e View commit details
    Browse the repository at this point in the history
  35. Address various telemetry issues

    - saved objects: removing indexing per elastic#43673
    - add schema and generate json per elastic#64942
    - move definitions over to collectors since saved objects is mostly empty at this point, and schema throws an error when it imports an obj instead of being defined inline
    - istanbul ignore saved_objects file since it doesn't have anything meaningful to test but was affecting code coverage
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    f920bd4 View commit details
    Browse the repository at this point in the history
  36. Disable plugin access if a normal user does not have access to App Se…

    …arch (#19)
    
    * Set up new server security dependency and configs
    
    * Set up access capabilities
    
    * Set up checkAccess helper/caller
    
    * Remove NoUserState component from the public UI
    
    - Since this is now being handled by checkAccess / normal users should never see the plugin at all if they don't have an account/access, the component is no longer needed
    
    * Update server routes to account for new changes
    
    - Remove login redirect catch from routes, since the access helper should now handle that for most users by disabling the plugin (superusers will see a generic cannot connect/error screen)
    - Refactor out new config values to a shared mock
    
    * Refactor Enterprise Search http call to hit/return new internal API endpoint
    
    + pull out the http call to a separate library for upcoming public URL work (so that other files can call it directly as well)
    
    * [Discussion] Increase timeout but add another warning timeout for slow servers
    
    - per recommendation/convo with Brandon
    
    * Register feature control
    
    * Remove no_as_account from UI telemetry
    
    - since we're no longer tracking that in the UI
    
    * Address PR feedback - isSuperUser check
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    2a14b5d View commit details
    Browse the repository at this point in the history
  37. Public URL support for Elastic Cloud (#21)

    * Add server-side public URL route
    
    - Per feedback from Kibana platform team, it's not possible to pass info from server/ to public/ without a HTTP call :[
    
    * Update MockRouter for routes without any payload/params
    
    * Add client-side helper for calling the new public URL API
    
    + API seems to return a URL a trailing slash, which we need to omit
    
    * Update public/plugin.ts to check and set a public URL
    
    - relies on this.hasCheckedPublicUrl to only make the call once per page load instead of on every page nav
    Constance authored and cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b1bf08a View commit details
    Browse the repository at this point in the history
  38. Fix failing feature control tests

    - Split up scenario cases as needed
    - Add plugin as an exception alongside ML & Monitoring
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0d0ca9c View commit details
    Browse the repository at this point in the history
  39. Address PR feedback

    - version: kibana
    - copy edits
    - Sass vars
    - code cleanup
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    a74b5e6 View commit details
    Browse the repository at this point in the history
  40. Casing feedback: change all plugin registration IDs from snake_case t…

    …o camelCase
    
    - note: current remainng snake_case exceptions are telemetry keys
    - file names and api endpoints are snake_case per conventions
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    972adcf View commit details
    Browse the repository at this point in the history
  41. Misc security feedback

    - remove set
    - remove unnecessary capabilities registration
    - telemetry namespace agnostic
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    9e52680 View commit details
    Browse the repository at this point in the history
  42. Security feedback: add warn logging to telemetry collector

    see elastic#66922 (comment)
    - add if statement
    - pass log dependency around (this is kinda medium, should maybe refactor)
    - update tests
    - move test file comment to the right file (was meant for telemetry route file)
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    15a8b15 View commit details
    Browse the repository at this point in the history
  43. Address feedback from Pierre

    - Remove unnecessary ServerConfigType
    - Remove unnecessary uiCapabilities
    - Move registerTelemetryRoute / SavedObjectsServiceStart workaround
    - Remove unnecessary license optional chaining
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    9c6acdd View commit details
    Browse the repository at this point in the history
  44. PR feedback

    Address type/typos
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    3b715b5 View commit details
    Browse the repository at this point in the history
  45. Fix telemetry API call returning 415 on Chrome

    - I can't even?? I swear charset=utf-8 fixed the same error a few weeks ago
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d72e988 View commit details
    Browse the repository at this point in the history
  46. Fix failing tests

    scottybollinger committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d6740f2 View commit details
    Browse the repository at this point in the history
  47. Update Enterprise Search functional tests (without host) to run on CI

    - Fix incorrect navigateToApp slug (hadn't realized this was a URL, not an ID)
    - Update without_host_configured tests to run without API key
    - Update README
    cee-chen committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    f305f11 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    2fbde3a View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Address PR feedback from Pierre

    - remove unnecessary authz?
    - remove unnecessary content-type json headers
    - add loggingSystemMock.collect(mockLogger).error assertion
    - reconstrcut new MockRouter on beforeEach for better sandboxing
    - fix incorrect describe()s -should be it()
    - pull out reusable mockDependencies helper (renamed/extended from mockConfig) for tests that don't particularly use config/log but still want to pass type definitions
    - Fix comment copy
    cee-chen committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8ce4486 View commit details
    Browse the repository at this point in the history