Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v30.2.0 #82730

Merged
merged 19 commits into from
Nov 17, 2020
Merged

Upgrade EUI to v30.2.0 #82730

merged 19 commits into from
Nov 17, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Nov 5, 2020 •
edited
Loading

Summary

eui@30.1.1 ⏩ eui@30.2.0

  • Expanded EuiPanel API means more CSS classes and therefore snapshot updates
  • New screen reader text in EuiLink for external URLs means that "get element text" methods in test suites capture more text.
    • This additional text is not relevant in most tests, so we've removed it in strict text-matching tests
    • removeExternalLinkText is the current approach
    • Open to other suggestions, especially from security_solutions owners, who have the most tests affected

30.2.0

  • Added labelWidth and descriptionDisplay props to EuiSuggestItem (#4180)
  • Added screen reader notification if EuiLink opens in a new window (#4172)
  • Set external prop to true if EuiLink opens in a new window (#4172)
  • Added float and margin props to EuiImage (#4209)
  • Added color and borderRadius props to EuiPanel (#4194)
  • Updated the use case for the EuiPanel prop hasShadow (#4194)
  • Deprecated the onClick, betaBadgeLabel, betaBadgeTooltipContent, and betaBadgeTitle props of EuiPanel (#4194)

Bug fixes

  • Fixed issue with labelDisplay not being passed to EuiSuggestItem (#4180)
  • Fixed copy in EuiDataGrid's header menu's sort actions (#4199)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 5, 2020
@thompsongl thompsongl marked this pull request as ready for review November 6, 2020 17:22
@thompsongl thompsongl requested review from a team as code owners November 6, 2020 17:22
@thompsongl thompsongl requested a review from a team November 6, 2020 17:22
@thompsongl thompsongl requested a review from a team as a code owner November 6, 2020 17:22
cjcenizal
cjcenizal approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to ES UI snapshots LGTM. Thanks for keeping us up-to-date, Greg!

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

legrego
legrego approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Spaces changes LGTM - tested locally

mikecote
mikecote approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting team related code LGTM

igoristic
igoristic approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good from Stack Monitoring side

dgieselaar
dgieselaar approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM!

@thompsongl thompsongl added the EUI label Nov 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@flash1293 flash1293 mentioned this pull request Nov 16, 2020
Merged
shahzad31
shahzad31 approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime snapshots changes LGTM !!

@apmmachine
Copy link
Contributor

💚 Build Succeeded

poffdeluxe
poffdeluxe approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation changes lgtm

patrykkopycinski
patrykkopycinski approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM/Endpoint LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 420.7KB 420.9KB +274.0B
ml 5.2MB 5.2MB +778.0B
securitySolution 7.9MB 7.9MB +510.0B
total +1.5KB

Distributable file count

id before after diff
default 42849 42848 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchprofiler 48.3KB 48.4KB +178.0B
securitySolution 165.0KB 165.2KB +198.0B
visTypeTimeseries 134.5KB 135.0KB +452.0B
total +828.0B
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
css 650.1KB 663.5KB +13.5KB
kbn-ui-shared-deps.@elastic.js 2.4MB 2.4MB +3.2KB
kbn-ui-shared-deps.js 4.8MB 4.8MB +7.0B
total +16.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit 8a7af5b into elastic:master Nov 17, 2020
@thompsongl thompsongl mentioned this pull request Nov 17, 2020
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Nov 17, 2020
@thompsongl
Upgrade EUI to v30.2.0 (elastic#82730)
6adbbae 
* eui to v30.2.0

* src snapshot updates

* x-pack euipanel snapshot updates

* x-pack external link updates

* security_solution_cypress external link text

* clean up
thompsongl added a commit that referenced this pull request Nov 18, 2020
@thompsongl
[7.x] Upgrade EUI to v30.2.0 (#82730) (#83588)
ce49c2a 
* Upgrade EUI to v30.2.0 (#82730)

* eui to v30.2.0

* src snapshot updates

* x-pack euipanel snapshot updates

* x-pack external link updates

* security_solution_cypress external link text

* clean up

* fix bad merge resolution
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 18, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-metrics-t…
2def566 
…o-node-details

* 'master' of github.com:elastic/kibana: (65 commits)
  update chromedriver dependency to 87 (elastic#83624)
  [TSVB] use new Search API for rollup search (elastic#83275)
  [TSVB] Y-axis has number formatting not considering all series formatters in the group (elastic#83438)
  [Logs UI] Update <LogStream /> internal state when its props change (elastic#83302)
  Add tag bulk action context menu (elastic#82816)
  [code coverage] adding plugin to flush coverage data (elastic#83447)
  [UsageCollection] Expose `KibanaRequest` to explicitly opted-in collectors (elastic#83413)
  Added eventBus to trigger and listen plotHandler event (elastic#83435)
  [Runtime fields] Editor phase 1 (elastic#81472)
  [Maps] Fix threshold alert issue resolving nested fields (elastic#83577)
  chore(NA): remove usage of unverified es snapshots (elastic#83589)
  [DOCS] Adds Elastic Contributor Program link (elastic#83561)
  Upgrade EUI to v30.2.0 (elastic#82730)
  Don't show loading screen during auto-reload (elastic#83376)
  Functional tests - fix esArchive mappings with runtime fields (elastic#83530)
  [deb/rpm] Create keystore after installation (elastic#76465)
  [rpm] Create default environment file at "/etc/sysconfig/kibana" (elastic#82144)
  [docker] removes workaround for missing crypto-policies-scripts subpackage (elastic#83455)
  [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439)
  adds xpack.security.authc.selector.enabled setting (elastic#83551)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@mikecote mikecote mikecote approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@legrego legrego legrego approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.