-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Surface on prem EMS #85729
[Maps] Surface on prem EMS #85729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm so far! just a few nits and a question.
x-pack/plugins/maps/public/classes/sources/ems_file_source/ems_file_source.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/components/ems_unavailable_message.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/classes/sources/ems_tms_source/ems_tms_source.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/classes/sources/ems_tms_source/ems_tms_source.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/public/classes/sources/ems_tms_source/ems_tms_source.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm! thanks.
does this still need to be a draft PR?
Pinging @elastic/kibana-gis (Team:Geo) |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
* master: (66 commits) [Alerting] fixes broken Alerting Example plugin (elastic#85774) [APM] Service overview instances table (elastic#85770) [Security Solution] Unskip timeline creation Cypress test (elastic#85871) properly recognize enterprise licenses (elastic#85849) [SecuritySolution][Detections] Adds SavedObject persistence to Signals Migrations (elastic#85690) [TSVB] Fix functional tests flakiness and unskip them (elastic#85388) [Fleet] Change permissions for Fleet enroll role (elastic#85802) Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 (elastic#84768) [Security Solution][Detections] Add alert source to detection rule action context (elastic#85488) [Discover] Don't display hide/show button for histogram when there's no time filter (elastic#85424) skip flaky suite (elastic#78553) License checks for alerts plugin (elastic#85649) skip flaky suite (elastic#84992) skip 'query return results valid for scripted field' elastic#78553 Allow action types to perform their own mustache variable escaping in parameter templates (elastic#83919) [ML] More machine learning links in doc_links_service.ts (elastic#85365) Removed Alerting & Event Log deprecated fields that should not be using (elastic#85652) Closes elastic#79995 by adding new tab in transaction details to show related trace logs. (elastic#85859) Fix outdated jest snapshot [Maps] Surface on prem EMS (elastic#85729) ...
Summary
Closes #80866
This PR makes following changes to current behavior:
includeElasticMapsService
is set tofalse
. Previously, it would also be off if on-prem was configured but there was no enterprise license. Now the card is always shown but will appear disabled if the enterprise license is not available for on-prem configurationsElastic Maps Service
toElastic Map Server
when on-prem is configuredemsUrl
in description and error messagesemsUrl
is set, check for enterprise-license and indicate in error-message of layer wizardChecklist
Delete any items that are not applicable to this PR.
For maintainers