-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime][Synthetics integration] remove optional tag from timeout field #99410
[Uptime][Synthetics integration] remove optional tag from timeout field #99410
Conversation
Pinging @elastic/uptime (Team:uptime) |
Now that I'm seeing this I'm wondering if it should be Optional after all. You can omit the |
@justinkambic @andrewvc I'm handling some of the defaults by matching what is defaulted in heartbeat to the default value that is populated in the fields on mount. Since the default timeout is 16 seconds, I use 16 seconds as the default value. I think it would be confusing, in some ways, if a user omitted this entirely and yet the timeout applied was still the default 16 seconds. I think current UX better aids in ensuring the policy that is created is the policy the user intended. |
@elasticmachine merge upstream |
…rom-timeout-field
@elasticmachine merge upstream |
…rom-timeout-field
That's a good point. Ok, I'm fine with it being required, esp. since we give the default value HB will use anyway. We also discussed offline the implications of requiring the timeout to be lower than the interval. When configuring HB manually, it will allow the interval to be below the timeout. We feel that since this is not a frequent configuration choice, and that it's probably not a good practice anyway, we will leave in the requirement that the request timeout be faster than the ping interval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
…tion (elastic#99410) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…tion (elastic#99410) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Fixes #99373
Removes Optional tag from timeout field