-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exploratory View] Mobile experience #99565
Conversation
@elasticmachine merge upstream |
.../public/components/shared/exploratory_view/configurations/mobile/response_duration_config.ts
Outdated
Show resolved
Hide resolved
added additional default filters & breakdowns.
updated agent filter name to 'iOS/swift'
… into mobile-experience
@elasticmachine merge upstream |
@bryce-b that was a good catch, i have fixed that. it will only show relevant filters now. |
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Love the framework you set up to easily add new data/report types.
}, | ||
], | ||
hasOperationType: false, | ||
defaultFilters: Object.keys(MobileFields), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain to me the difference between defaultFilters
and filters
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry about naming here. i will update these soon. default filters should be uiFilters and filters should be default/base filters here.
status: FETCH_STATUS.SUCCESS, | ||
}, | ||
})); | ||
}; | ||
switch (app) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this could have a larger impact on the observability overview page. Should I smoke test the overview page as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be helpful
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
History
To update your PR or re-run it, just comment with: cc @shahzad31 |
💔 Backport failed
To backport manually run: |
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (447 commits) skip flaky suite (elastic#102366) [Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details (elastic#102274) Add email connector info for Elastic Cloud (elastic#91363) [Workplace Search] remove or replace xs props for text on source connect view (elastic#102663) Do not double register dashboard url generator (elastic#102599) [TSVB] Replaces EuiCodeEditor 👉 Monaco editor (elastic#100684) [Discover] Update kibana.json adding owner and description (elastic#102292) [Exploratory View] Mobile experience (elastic#99565) chore(NA): moving @kbn/ui-shared-deps into bazel (elastic#101669) [TSVB] Index pattern select field disappear in Annotation tab (elastic#102314) [Security Solution][Endpoint][Host Isolation] Fixes bug where host isolation/unisolation works from alert details (elastic#102581) TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (elastic#102494) [Logs UI] Add `event.original` fallback to message reconstruction rules (elastic#102236) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co> Co-authored-by: Shahzad <shahzad.muhammad@elastic.co> Co-authored-by: Bryce Buchanan <bryce.buchanan@elastic.co> Co-authored-by: Alexander Wert <alexander.wert@elastic.co>
Summary
Added mobile apm ios data, Latency, CPU Usage, Memory Usage
This only adds these parts in the exploratory view, this PR doesn't covers adding a link from APM view
Follow up would be to work in APM to add links like defined in #100759
APM changes
Had to update APM has data call to return the indices that are being used alongside has data boolean.