Manually generated the missed docs between 2025-07-15 ~ 2025-07-28. #1910
Conversation
|
😨 I have no idea what |
| [cols="<,<,<",options="header",] | ||
| |======================================================================= | ||
| |Setting |Input type|Required | ||
| | <<{version}-plugins-{type}s-{plugin}-aggregation_fields>> |<<hash,hash>>|No |
There was a problem hiding this comment.
This manually generated PR is using the old <<hash,hash>> (8x and Asciidoc compatible), but the references should be in this format: {logstash-ref}/configuration-file-structure.html#hash[hash] to link correctly in 9.0+.
Off the top of my head, I'm not sure why this isn't a problem for auto-generated plugin docs. (Check out the PR where 4.2.0 was updated.)
There was a problem hiding this comment.
To be clear, it's not just the format that has changed. The file location has changed, too.
There was a problem hiding this comment.
Ah didn't notice that we had --repair option, will fix this in a moment.
There was a problem hiding this comment.
Docs got updated and {logstash-ref}/configuration-file-structure.html#hash[hash] changes appeared, was missed due to --repair option on my local.
CI seems also 🟢 happy!
It's a link format thing, and ci would error on every single one (hash, field, boolean, array, etc.) I left a note inline to illustrate. |
mashhurs
force-pushed
the
missed-plugin-docs
branch
from
327ee98 to
83ddacc
Compare
Checked on my local if missed the plugin docs between 2025-07-15 ~ 2025-07-28 and got this commit.