[ML] Format memory instrumentation output #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
approved these changes
Feb 24, 2020
| this->writeMemory(step); | ||
| // this->writeProgress(step); | ||
| int64_t timestamp = core::CTimeUtils::toEpochMs(core::CTimeUtils::now()); | ||
| this->writeMemory(timestamp); |
There was a problem hiding this comment.
nit: use std::int64_t, or how about just this->writeMemory(core::CTimeUtils::toEpochMs(core::CTimeUtils::now());
There was a problem hiding this comment.
I will have to write the time stamp into analysis object as well. Thus, I prefer to keep it as a variable.
| } | ||
|
|
||
| void CDataFrameAnalysisInstrumentation::writeState(std::uint32_t step) { | ||
| this->writeProgress(step); | ||
| this->writeMemory(step); | ||
| // this->writeProgress(step); |
There was a problem hiding this comment.
I am a bit confused with this commented out line. Will progress be written out from here instead of CDataFrameAnalyzer?
dimitris-athanasiou
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
LGTM2 I opened elastic/elasticsearch#52778 which is a prerequisite for this PR to be merged
|
This is ready to be merged now from the java side. |
|
run tests |
|
run elasticsearch-ci |
|
retest |
tveasey
added a commit
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR activates memory instrumentation and formats it according to the specified JSON format.