Skip to content

[ML] Fix printing values for multiclass feature importance #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2020
Merged

[ML] Fix printing values for multiclass feature importance #1144

merged 3 commits into from
Apr 17, 2020

Conversation

valeriy42
Copy link
Contributor

@valeriy42 valeriy42 commented Apr 16, 2020 •
edited
Loading

This PR fixes elastic/ml-team#337 which happens when the number of classes in the configuration differs from the number of recognized classes.

@valeriy42 valeriy42 requested a review from tveasey April 16, 2020 11:50
tveasey
tveasey approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM, but I'd slightly reword the documentation.

@valeriy42 @tveasey
Update docs/CHANGELOG.asciidoc
4e06b83 
Co-Authored-By: Tom Veasey <tveasey@users.noreply.github.com>
@valeriy42 valeriy42 merged commit 23185a0 into elastic:master Apr 17, 2020
@valeriy42 valeriy42 deleted the fix-shap-class-values branch April 17, 2020 10:35
valeriy42 added a commit to valeriy42/ml-cpp that referenced this pull request Apr 17, 2020
@valeriy42
[ML] Fix printing values for multiclass feature importance (elastic#1144
4a8cdfc 
)

Fix classification job failures when number of classes in configuration differs from the number of classes present in the training data.
@valeriy42 valeriy42 mentioned this pull request Apr 17, 2020
Merged
@valeriy42 valeriy42 mentioned this pull request May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tveasey tveasey tveasey approved these changes

Assignees
No one assigned
Labels
>bug :ml v7.7.1 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valeriy42 @tveasey @droberts195