[ML] Fix a bug in adaptive local regression #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t least the bucket length, but doesn't matter if we're slightly over)
|
retest |
|
It looks like some unit tests are failing - same two on both Windows and Linux:
|
Annoying fixing one set of tests broke these. Hopefully these should now be passing too. |
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Apr 27, 2020
tveasey
added a commit
that referenced
this pull request
Apr 28, 2020
This was referenced May 10, 2020
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
May 14, 2020
tveasey
added a commit
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were hitting the error when some the time intervals we use to split cyclic components into local regression models had negative length. With this change, I impose a constraint that they have positive length explicitly. I also moved the (rather specific code) which ensures that every interval has a minimum length, so that it receives at least one update per period, out of
CTools. At the same time I simplified it to make explicitly handling the constraint easier.I was able to reproduce the error following the instruction in this comment and verified that this change fixes it. Closes #142.