Skip to content

Conversation

davidkyle
Copy link
Member

Following the changes in #1773 this causes a rebuild of the unit tests when the compiled class files change

@droberts195
Copy link
Contributor

In this case the Windows CI failed, but it did actually run and found an error:

CBufferedIStreamAdapter.obj : error LNK2019: unresolved external symbol __imp_ntohl referenced in function "private: bool __cdecl ml::torch::CBufferedIStreamAdapter::parseSizeFromStream(unsigned __int64 &)" (?parseSizeFromStream@CBufferedIStreamAdapter@torch@ml@@AEAA_NAEA_K@Z)
ml_test.exe : fatal error LNK1120: 1 unresolved externals

So USE_NET=1 needs adding to the Makefile.

@davidkyle
Copy link
Member Author

The build passed on all platforms except macOS ARM as expected

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle merged commit 58b95a1 into elastic:feature/pytorch-inference Mar 9, 2021
@davidkyle davidkyle deleted the makefile-fix branch March 9, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants