[ML] Persist state for correcting loss to account for model size when training a boosted tree #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Apr 15, 2021
… training a boosted tree (elastic#1848) We were missing state used to adjust the loss function to select the best hyperparameters based on model size. This would sometimes cause us to select different hyperparameters if the modelling failed and was restarted during training.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing state used to adjust the loss function to select the best hyperparameters based on model size. This would sometimes cause us to select different hyperparameters if the modelling failed and was restarted during training.
Note that this already tested by
testRunBoostedTreeRegressionTrainingWithStateRecoverybut only fails if the change causes us to select a different model so this doesn't reliably fail.