[ML] Make atomic operations safer for aarch64 #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a followup to elastic#1888 which makes one more relaxed store of an atomic variable in the CStringStore class use release memory ordering rather than relaxed. Additionally, a relaxed load is changed to use acquire memory ordering in the CIntegration class. These changes only have an effect on the aarch64 architecture. Relates elastic#1885
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
May 10, 2021
This PR is a followup to elastic#1888 which makes one more relaxed store of an atomic variable in the CStringStore class use release memory ordering rather than relaxed. Additionally, a relaxed load is changed to use acquire memory ordering in the CIntegration class. These changes only have an effect on the aarch64 architecture. Backport of elastic#1893
droberts195
added a commit
that referenced
this pull request
May 10, 2021
This PR is a followup to #1888 which makes one more relaxed store of an atomic variable in the CStringStore class use release memory ordering rather than relaxed. Additionally, a relaxed load is changed to use acquire memory ordering in the CIntegration class. These changes only have an effect on the aarch64 architecture. Backport of #1893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #1888 which makes one more relaxed
store of an atomic variable in the CStringStore class use
release memory ordering rather than relaxed.
Additionally, a relaxed load is changed to use acquire memory
ordering in the CIntegration class.
These changes only have an effect on the aarch64 architecture.
Relates #1885