[ML] Fix potential undefined behaviour in classification and regression training #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest |
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Aug 23, 2021
…on training (elastic#1997) The issue was caused by a mismatch in the condition to decide whether to split the root node and the condition to decide whether to bother to initialise all its state. In particular, we would, if we got very unlucky, try and split having not properly initialised state. This updates the offending condition so we always properly initialise state when we're going to try and split. Closes elastic#1956.
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Aug 23, 2021
…on training (elastic#1997) The issue was caused by a mismatch in the condition to decide whether to split the root node and the condition to decide whether to bother to initialise all its state. In particular, we would, if we got very unlucky, try and split having not properly initialised state. This updates the offending condition so we always properly initialise state when we're going to try and split. Closes elastic#1956.
This was referenced Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by a mismatch in the condition to decide whether to split the root node and the condition to decide whether to bother to initialise all its state. In particular, we would, if we got very unlucky, try and split having not properly initialised state. This updates the offending condition so we always properly initialise state when we're going to try and split. (There was also a typo this fixes.)
Closes #1956.