Skip to content

[ML] Set model state compatibility version to 8.0.0 #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

droberts195
Copy link
Contributor

Setting this for the new major version gives us a nice
clean break for model state compatibility. Model snapshots
generated by 8.0 will not be loadable by 7.x nodes, and
in the version where we eventually stop supporting upgrades
from 7.x to the latest version we'll be able to remove all
the model state backwards compatibility code related to
version 7.x.

Proactively avoiding a repeat of elastic/elasticsearch#81011

Setting this for the new major version gives us a nice
clean break for model state compatibility.  Model snapshots
generated by 8.0 will not be loadable by 7.x nodes, and
in the version where we eventually stop supporting upgrades
from 7.x to the latest version we'll be able to remove all
the model state backwards compatibility code related to
version 7.x.

Proactively avoiding a repeat of elastic/elasticsearch#81011
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit 6dde25e into elastic:main Nov 25, 2021
@droberts195 droberts195 deleted the increment_model_state_version branch November 25, 2021 11:11
droberts195 added a commit to droberts195/ml-cpp that referenced this pull request Nov 25, 2021
Setting this for the new major version gives us a nice
clean break for model state compatibility.  Model snapshots
generated by 8.0 will not be loadable by 7.x nodes, and
in the version where we eventually stop supporting upgrades
from 7.x to the latest version we'll be able to remove all
the model state backwards compatibility code related to
version 7.x.

Backport of elastic#2139
droberts195 added a commit that referenced this pull request Nov 25, 2021
Setting this for the new major version gives us a nice
clean break for model state compatibility.  Model snapshots
generated by 8.0 will not be loadable by 7.x nodes, and
in the version where we eventually stop supporting upgrades
from 7.x to the latest version we'll be able to remove all
the model state backwards compatibility code related to
version 7.x.

Backport of #2139
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Nov 25, 2021
droberts195 added a commit to elastic/elasticsearch that referenced this pull request Nov 25, 2021
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Nov 25, 2021
droberts195 added a commit to elastic/elasticsearch that referenced this pull request Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants