Skip to content

[8.0] [ML] Set model state compatibility version to 8.0.0 #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2021
Merged

[8.0] [ML] Set model state compatibility version to 8.0.0 #2140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

=== Bug Fixes

* ...
* Set model state compatibility version to 8.0.0. (See {ml-pull}2139[#2139].)

== {es} version 8.0.0-beta1

Expand Down
9 changes: 6 additions & 3 deletions lib/api/CAnomalyJob.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,12 @@ const std::string INTERIM_BUCKET_CORRECTOR_TAG("k");
//! Newer versions are able to read the model state of older versions, but older
//! versions cannot read the model state of newer versions following a breaking
//! change. This constant tells the node assignment code not to load new model states
//! on old nodes in a mixed version cluster. (The last breaking change was in 7.11 in
//! lib/maths/CTimeSeriesDecomposition.cc in https://github.com/elastic/ml-cpp/pull/1614.)
const std::string MODEL_SNAPSHOT_MIN_VERSION("7.11.0");
//! on old nodes in a mixed version cluster. (Most recently this has been updated to
//! 8.0.0 so that we have a clean break of state compatibility on the major version
//! boundary. Model snapshots generated in 8.x will not be loadable by 7.x, and
//! when 7.x is end-of-life we'll be able to remove all the 7.x state backwards
//! compatibility code.)
const std::string MODEL_SNAPSHOT_MIN_VERSION("8.0.0");

//! Persist state as JSON with meaningful tag names.
class CReadableJsonStatePersistInserter : public core::CJsonStatePersistInserter {
Expand Down