Skip to content

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented Mar 31, 2022

Previously, we would enter fine tuning loop even if we exited early in the event of restart from failover. This adds state to record early exit so we pick up correctly. Also, to monitor progress correctly we need to always start progress monitoring for final train, independent of whether we're training using a hold set or cross-validation.

@tveasey
Copy link
Contributor Author

tveasey commented Mar 31, 2022

Fixes elastic/elasticsearch#85536.

Copy link
Contributor

@valeriy42 valeriy42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch.

@tveasey tveasey merged commit 77d3b35 into elastic:main Mar 31, 2022
@tveasey tveasey deleted the fix-progress-monitoring branch March 31, 2022 20:37
benwtrent added a commit to elastic/elasticsearch that referenced this pull request Apr 1, 2022
ml-cpp build containing fix elastic/ml-cpp#2251 has been uploaded.

enabling tests again.

closes #85536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants