Skip to content

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented Oct 18, 2018

This makes changes driven by latest round reviewing 6.5 results against our QA suite. It primarily targets model robustness to outliers.

In particular, it

  1. Mitigates the impact of outliers on change point detection,
  2. Delays detecting changes for slightly longer (to reduce false positives detecting time shifts),
  3. Increases the sample p-value at we apply minimum weight for model update.

Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I do note the CI error, however this does appear spurious

@tveasey tveasey merged commit 5aafd3b into elastic:master Oct 19, 2018
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Oct 19, 2018
@tveasey tveasey deleted the enhancement/robustness branch May 1, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants