Skip to content

[ML] Log 'No statistics at.. ' as a warning #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

davidkyle
Copy link
Member

The condition is considered harmless and should not be logged as an error

@davidkyle
Copy link
Member Author

@edsavage this change was provoked by the error message below. Looking at the current bucket time [-1,899) I think it should have been fixed in #2410. Do you think there is still an issue here or we can go ahead and change the log level?

[gallery_sum_bytes] [autodetect/179] [CIndividualModel.cc@136] No statistics at 1719197550 for sum bytes partition=clientip, current bucket = [-1,899), partitionFieldValue = 175.144.21.153, personName = | repeated [5]

@edsavage
Copy link
Contributor

edsavage commented Jul 1, 2024

@edsavage this change was provoked by the error message below. Looking at the current bucket time [-1,899) I think it should have been fixed in #2410. Do you think there is still an issue here or we can go ahead and change the log level?

[gallery_sum_bytes] [autodetect/179] [CIndividualModel.cc@136] No statistics at 1719197550 for sum bytes partition=clientip, current bucket = [-1,899), partitionFieldValue = 175.144.21.153, personName = | repeated [5]

I think that it's safe and appropriate to downgrade the log level for that message @davidkyle, thanks!

@davidkyle davidkyle requested a review from edsavage July 9, 2024 08:46
Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle merged commit c9a5bf7 into elastic:main Jul 10, 2024
13 checks passed
@davidkyle davidkyle deleted the make-warning branch July 10, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants