Skip to content

[ML] Windows 2022: Upgrade PyTorch to version 2.5.1 #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2024
Merged

[ML] Windows 2022: Upgrade PyTorch to version 2.5.1 #2799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7aa5bd
[ML] Windows 2022: Upgrade PyTorch to version 2.5.1
edsavage Dec 10, 2024
83154d4
Update changelog
edsavage Dec 10, 2024
39e78e1
Refer to latest Windows 2022 VM
edsavage Dec 10, 2024
042a945
Be more reilient to errors in powershell script
edsavage Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipelines/build_windows.json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def main(args):
"provider": "gcp",
"machineType": "c2-standard-16",
"minCpuPlatform": "Intel Cascade Lake",
"image": "family/ml-cpp-3-windows-2022",
"image": "family/ml-cpp-4-windows-2022",
},
"commands": [
f'if ( "{args.action}" -eq "debug" ) {{\$Env:ML_DEBUG="1"}}',
Expand Down
6 changes: 3 additions & 3 deletions build-setup/windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ On the "Advanced Options" screen, check "Install for all users" and "Add Python

For the time being, do not take advantage of the option on the final installer screen to reconfigure the machine to allow paths longer than 260 characters. We still support Windows versions that do not have this option.

### PyTorch 2.5.0
### PyTorch 2.5.1

(This step requires a lot of memory. It failed on a machine with 12GB of RAM. It just about fitted on a 20GB machine. 32GB RAM is recommended.)

Expand All @@ -216,7 +216,7 @@ Next, in a Git bash shell run:

```
cd /c/tools
git clone --depth=1 --branch=v2.5.0 https://github.com/pytorch/pytorch.git
git clone --depth=1 --branch=v2.5.1 https://github.com/pytorch/pytorch.git
cd pytorch
git submodule sync
git submodule update --init --recursive
Expand Down Expand Up @@ -272,7 +272,7 @@ set USE_QNNPACK=OFF
set USE_PYTORCH_QNNPACK=OFF
set USE_XNNPACK=OFF
set MSVC_Z7_OVERRIDE=OFF
set PYTORCH_BUILD_VERSION=2.5.0
set PYTORCH_BUILD_VERSION=2.5.1
set PYTORCH_BUILD_NUMBER=1
python setup.py install
```
Expand Down
8 changes: 4 additions & 4 deletions dev-tools/build_windows_third_party_deps.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ mv "C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\$f\
# Build and install PyTorch (this may take a while)
Write-Host "--- Installing PyTorch locally"
cd c:\tools
git clone --depth=1 --branch=v2.5.0 https://github.com/pytorch/pytorch.git
git clone --depth=1 --branch=v2.5.1 https://github.com/pytorch/pytorch.git
cd pytorch
git submodule sync
git submodule update --init --recursive
Expand All @@ -131,7 +131,7 @@ set USE_QNNPACK=OFF
set USE_PYTORCH_QNNPACK=OFF
set USE_XNNPACK=OFF
set MSVC_Z7_OVERRIDE=OFF
set PYTORCH_BUILD_VERSION=2.5.0
set PYTORCH_BUILD_VERSION=2.5.1
set PYTORCH_BUILD_NUMBER=1
python setup.py install
Write-Host "--- Done Installing PyTorch locally"
Expand All @@ -158,9 +158,9 @@ mv "C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\$f\

# Uninstall python, it was only needed for the PyTorch build
& c:\tools\$PythonArchive /uninstall /quiet
rm c:\Python310 -recurse -force
rm c:\Python310 -recurse -force -ErrorAction Ignore

# Remove c:\tools entirely
cd c:\
rm c:\tools -recurse -force
rm c:\tools -recurse -force -ErrorAction Ignore

2 changes: 1 addition & 1 deletion docs/CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

=== Enhancements

* Update the PyTorch library to version 2.5.0. (See {ml-pull}2783[#2783], {ml-pull}2778[#2778].)
* Update the PyTorch library to version 2.5.1. (See {ml-pull}2783[#2783], {ml-pull}2799[#2799].)
* Upgrade Boost libraries to version 1.86. (See {ml-pull}2780[#2780], {ml-pull}2779[#2779].)

== {es} version 8.16.0
Expand Down