Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix for CPoissonMeanConjugate sampling error. #335

Merged
merged 3 commits into from Dec 11, 2018
Merged

[ML] Fix for CPoissonMeanConjugate sampling error. #335

merged 3 commits into from Dec 11, 2018

Conversation

edsavage
Copy link
Contributor

@edsavage edsavage commented Dec 11, 2018 •
edited by lcawl

Fix for "sample out of bounds" error generated from
CPoissonMeanConjugate

Release note: Fix cause of "Sample out of bounds" error message.

@edsavage
[ML] Fix for CPoissonMeanConjugate sampling error.
4c4a91c 
Fix for "sample out of bounds" error generated from
CPoissonMeanConjugate
tveasey
tveasey requested changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there needs to be a small change to the handling of the negative value.

lib/maths/CPoissonMeanConjugate.cc Outdated Show resolved Hide resolved
tveasey
tveasey approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsavage edsavage merged commit 9f15ef8 into elastic:master Dec 11, 2018
edsavage added a commit to edsavage/ml-cpp that referenced this pull request Dec 11, 2018
@edsavage
[ML] Fix for CPoissonMeanConjugate sampling error. (elastic#335)
059f498 
Fix for "sample out of bounds" error generated from
CPoissonMeanConjugate
@edsavage edsavage mentioned this pull request Dec 11, 2018
Merged
edsavage added a commit that referenced this pull request Dec 11, 2018
@edsavage
[ML] Fix for CPoissonMeanConjugate sampling error. (#335) (#338)
d6dfc47 
Fix for "sample out of bounds" error generated from
CPoissonMeanConjugate

Backports #335
@edsavage edsavage mentioned this pull request Dec 12, 2018
Closed
@edsavage edsavage deleted the poisson_mean_conjugate_bounds_error branch April 12, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tveasey tveasey tveasey approved these changes

Assignees
No one assigned
Labels
>bug :ml review v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edsavage @tveasey