[ML] Missing variable initialisation causing spurious model reinitialisation for lat/long function #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
changed the title
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Sep 4, 2019
…isation for lat/long function (elastic#641)
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Sep 4, 2019
…isation for lat/long function (elastic#641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing the initialisation of the return type from updating the trend for multivariate models (this only, potentially, affects results for the lat/long function). This could in rare circumstances cause us to reinitialise the model.
This is a good candidate cause for some sporadic test failures we've seen.