Skip to content

[ML] Correct function description for population lat_long #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2018
Merged

[ML] Correct function description for population lat_long #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ec7b60
[ML] Correct function description for population lat_long
dimitris-athanasiou May 2, 2018
ce80663
Add bug fix in changelog
dimitris-athanasiou May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@

=== Bug Fixes

Function description for population lat_long results should be lat_long instead of mean ({pull}81[#81])

=== Regressions

=== Known Issues
3 changes: 2 additions & 1 deletion lib/model/ModelTypes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,7 +1537,6 @@ const std::string& outputFunctionName(EFeature feature) {
case E_PopulationMeanByPersonAndAttribute:
case E_PopulationLowMeanByPersonAndAttribute:
case E_PopulationHighMeanByPersonAndAttribute:
case E_PopulationMeanLatLongByPersonAndAttribute:
case E_PopulationMeanVelocityByPersonAndAttribute:
return model::CAnomalyDetector::MEAN_NAME;
case E_PopulationMedianByPersonAndAttribute:
Expand All @@ -1559,6 +1558,8 @@ const std::string& outputFunctionName(EFeature feature) {
case E_PopulationHighSumByBucketPersonAndAttribute:
case E_PopulationSumVelocityByPersonAndAttribute:
return model::CAnomalyDetector::SUM_NAME;
case E_PopulationMeanLatLongByPersonAndAttribute:
return model::CAnomalyDetector::LAT_LONG_NAME;

// Peers event rate features
case E_PeersCountByBucketPersonAndAttribute:
Expand Down
Loading