[ML] Account for data frame memory in the peak memory usage estimate for classification and regression #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mory usage estimate
valeriy42
approved these changes
Feb 14, 2020
| @@ -133,7 +132,7 @@ CBoostedTreeImpl::CBoostedTreeImpl(std::size_t numberThreads, | |||
| m_BestHyperparameters{ | |||
| m_Regularization, m_DownsampleFactor, m_Eta, | |||
| m_EtaGrowthRatePerTree, m_MaximumNumberTrees, m_FeatureBagFraction}, | |||
| m_Instrumentation{instrumentation} { | |||
| m_Instrumentation{instrumentation != nullptr ? instrumentation : &INSTRUMENTATION_STUB} { | |||
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Feb 14, 2020
…for classification and regression (elastic#996)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't accounting for the data frame's memory usage when reporting peak memory usage for training. Also, we were missing some state when estimating peak memory usage during the line searches to initialise hyperparameters.
I've also taken the opportunity to more fully migrate instrumentation of training to use the new instrumentation object and provide better automatic stubbing.