-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Alerts page visualizations, new treemap view #2280
Conversation
Adds new subtopic Updates & adds new images Updates "Manage detection alerts"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing the new Visualize detection alerts documentation @joepeeples!
The new content provides an easy-to-digest overview, while also relaying the details when relevant, i.e. For groupings with a lot of unique values, the top 1,000 results are displayed.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few small suggestions. This is a really educational topic - great job on it!
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @joepeeples We have reviewed the shared preview for Alerts page visualizations and new treemap view and all the required change are present and correct. ✔️ Hence we are adding "QA:Validated" label to it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @joepeeples LGTM 🚀
Updated the risk score ranges for tile colors, per #2341 and esp. elastic/kibana#139195 (comment). |
Hi @joepeeples We have reviewed the shared preview for Alerts page visualizations and new treemap view and all the required change are present and correct. ✔️ Screenshots: Hence, we are adding "QA:Validated" label to it. Thanks! |
* Big first draft Adds new subtopic Updates & adds new images Updates "Manage detection alerts" * Revise topic title * Another tiny edit * Update screenshots: Manage rules button * More edits, rename GIF * More. edits. * Clean out comments, final (?) edits * Apply suggestions from Nastasha's review Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Apply suggestions from review * Corrects risk score ranges for tile colors Per elastic/kibana/issues/139195 Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit 5ef68f8)
* Big first draft Adds new subtopic Updates & adds new images Updates "Manage detection alerts" * Revise topic title * Another tiny edit * Update screenshots: Manage rules button * More edits, rename GIF * More. edits. * Clean out comments, final (?) edits * Apply suggestions from Nastasha's review Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> * Apply suggestions from review * Corrects risk score ranges for tile colors Per elastic/kibana/issues/139195 Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com> (cherry picked from commit 5ef68f8) Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Resolves #2261.
Previews:
Note: The animation
treemap-click.gif
was captured right before the "Manage rules" link was turned into a button. For now, I'm deprioritizing getting this GIF updated just for that minor detail, since it doesn't affect the functionality being illustrated, and it involves a lot of setup work.