Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Alerts page visualizations, new treemap view #2280

Merged
merged 16 commits into from
Aug 24, 2022

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Aug 9, 2022

Resolves #2261.

Previews:

Note: The animation treemap-click.gif was captured right before the "Manage rules" link was turned into a button. For now, I'm deprioritizing getting this GIF updated just for that minor detail, since it doesn't affect the functionality being illustrated, and it involves a lot of setup work.

Adds new subtopic
Updates & adds new images
Updates "Manage detection alerts"
Copy link

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing the new Visualize detection alerts documentation @joepeeples!

The new content provides an easy-to-digest overview, while also relaying the details when relevant, i.e. For groupings with a lot of unique values, the top 1,000 results are displayed.

LGTM 🚀

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few small suggestions. This is a really educational topic - great job on it!

docs/detections/alerts-visualizations.asciidoc Outdated Show resolved Hide resolved
docs/detections/alerts-visualizations.asciidoc Outdated Show resolved Hide resolved
@joepeeples joepeeples mentioned this pull request Aug 18, 2022
20 tasks
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joepeeples joepeeples added the readyforQA PRs that are ready for QA review. label Aug 18, 2022
@ghost
Copy link

ghost commented Aug 22, 2022

Hi @joepeeples

We have reviewed the shared preview for Alerts page visualizations and new treemap view and all the required change are present and correct. ✔️

Screenshots:
alerts-viz-treemap
alert-page

Hence we are adding "QA:Validated" label to it.

Thanks!

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Aug 22, 2022
Copy link

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @joepeeples LGTM 🚀

@joepeeples
Copy link
Contributor Author

Updated the risk score ranges for tile colors, per #2341 and esp. elastic/kibana#139195 (comment).

@ghost
Copy link

ghost commented Aug 24, 2022

Hi @joepeeples

We have reviewed the shared preview for Alerts page visualizations and new treemap view and all the required change are present and correct. ✔️

Screenshots:

Screenshot (839)

Hence, we are adding "QA:Validated" label to it.

Thanks!

@joepeeples joepeeples merged commit 5ef68f8 into main Aug 24, 2022
mergify bot pushed a commit that referenced this pull request Aug 24, 2022
* Big first draft

Adds new subtopic
Updates & adds new images
Updates "Manage detection alerts"

* Revise topic title

* Another tiny edit

* Update screenshots: Manage rules button

* More edits, rename GIF

* More. edits.

* Clean out comments, final (?) edits

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Apply suggestions from review

* Corrects risk score ranges for tile colors

Per elastic/kibana/issues/139195

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 5ef68f8)
joepeeples added a commit that referenced this pull request Aug 24, 2022
* Big first draft

Adds new subtopic
Updates & adds new images
Updates "Manage detection alerts"

* Revise topic title

* Another tiny edit

* Update screenshots: Manage rules button

* More edits, rename GIF

* More. edits.

* Clean out comments, final (?) edits

* Apply suggestions from Nastasha's review

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>

* Apply suggestions from review

* Corrects risk score ranges for tile colors

Per elastic/kibana/issues/139195

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 5ef68f8)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@joepeeples joepeeples deleted the issue-2261-alerts-viz-treemap branch August 24, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Alerts QA:Validated Issue has been Validated by QA Team Team: Docs Team: Threat Hunting Formerly Data Visibility v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Alerts page visualizations, new treemap view
5 participants