Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for capabilities flag #295

Merged
merged 5 commits into from
Jun 3, 2021

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam commented Jun 2, 2021

npx @elastic/synthetics examples/todos --capability metrics trace --capability filmstrips
  • Also deprecated the previous --trace, --metrics, --filmstrips flag which are not required anymore and not used by heartbeat currently.

@apmmachine
Copy link

apmmachine commented Jun 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #295 updated

  • Start Time: 2021-06-02T22:14:35.687+0000

  • Duration: 12 min 13 sec

  • Commit: 027ff3c

Test stats 🧪

Test Results
Failed 0
Passed 99
Skipped 0
Total 99

Trends 🧪

Image of Build Times

Image of Tests

src/parse_args.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs one small tweak

src/parse_args.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit b3a696d into elastic:master Jun 3, 2021
@vigneshshanmugam vigneshshanmugam deleted the add-capabilities branch June 3, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flags/capabilities system
3 participants