Don't recreate when field is removed #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-yomo
force-pushed
the
dont-recreate-when-field-is-removed
branch
3 times, most recently
from
0c8e877 to
c6fe0e3
Compare
tobio
reviewed
Dec 19, 2022
Co-authored-by: Toby Brain <tobio85@gmail.com>
tobio
force-pushed
the
dont-recreate-when-field-is-removed
branch
from
05bee1e to
dad2f8e
Compare
tobio
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #227
This PR changes not to recreate when field is removed in a new mapping (= mapping defined in terraform), not to cause recreate mainly for dynamically added fields.
Ignoring field removal is the default behaviour of Elasticsearch, so it'll be aligned wit Elasticsearch too.
📝 This PR is branched from #231