Skip to content

Conversation

tobio
Copy link
Member

@tobio tobio commented Feb 15, 2023

Fixes #5

@tobio tobio requested a review from webfella February 15, 2023 12:24
@tobio tobio self-assigned this Feb 15, 2023
Copy link

@webfella webfella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great mate! ⚡

t.Fatal("KIBANA_ENDPOINT must be set for acceptance tests to run")
}

// Technically ES tests can use the API Key, however username/password is required for Kibana tests.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobio tobio merged commit e662d3f into main Feb 20, 2023
@tobio tobio deleted the kibana-spaces branch February 20, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] support kibana spaces

2 participants