Don't require elasticsearch for Kibana resources #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimuon
previously approved these changes
Sep 13, 2023
|
Still, it looks like we also have to change the way kibana client is built. |
dimuon
reviewed
Sep 13, 2023
internal/kibana/space.go
Outdated
| if diags.HasError() { | ||
| return diags | ||
| id := d.Id() | ||
| if strings.Contains(id, "/") { |
There was a problem hiding this comment.
It's a trivial check, but maybe it makes sense to create a helper function (e.g. IsCompositeId) next to func CompositeIdFromStr to keep the details of composite ID creation in one place.
tobio
force-pushed
the
kibana-space-no-es
branch
from
148d197 to
f78706e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #345
Kibana spaces shouldn't need Elasticsearch to be configured to work.