Fix mapping of webhook connectors that is stored in tfstate #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimuon
previously approved these changes
Sep 27, 2023
Co-authored-by: Dmitry Onishchenko <8962171+dimuon@users.noreply.github.com>
Co-authored-by: Dmitry Onishchenko <8962171+dimuon@users.noreply.github.com>
|
Pushed an update with the formatting. Looks like you need to approve again. Odd that it looked fine in my ide |
It could be that your IDE uses spaces instead of tabs. |
tobio
added a commit
to wandergeek/terraform-provider-elasticstack
that referenced
this pull request
Oct 1, 2023
…ramework * origin/main: Fix mapping of webhook connectors that is stored in tfstate (elastic#433) Bump version for v0.8.0 Fix Kibana SLO panic `histogram_custom_indicator` (elastic#430) Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.26.1 to 2.29.0 (elastic#422) Bump github.com/hashicorp/terraform-plugin-docs in /tools (elastic#384) Bump github.com/golangci/golangci-lint from 1.54.1 to 1.54.2 in /tools (elastic#409) Bump actions/checkout from 3 to 4 (elastic#421) fix: update component documentation (elastic#420) Add support for the .slack_api connector (elastic#419)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connectors were only properly storing url in the config in the tfstate file as they were being mapped to Tines.
Fix #388