Skip to content

Fix Fleet Agent Policy monitoring settings #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 26, 2023
Merged

Fix Fleet Agent Policy monitoring settings #448

merged 5 commits into from
Oct 26, 2023

Conversation

taylor-swanson
Copy link
Contributor

  • Fixed Fleet Agent Policy monitoring settings not being applied correctly, particularily when the values would be set to false.
  • Update Fleet Agent Policy acceptance tests to verify disabling monitoring works as intended.
  • Fix ELASTICSEARCH_INSECURE environment variable not being set.

Related:

@taylor-swanson
Fix Fleet Agent Policy monitoring settings
3253ea6 
- Fixed Fleet Agent Policy monitoring settings not being applied
correctly, particularily when the values would be set to false.
- Update Fleet Agent Policy acceptance tests to verify disabling
monitoring works as intended.
- Fix ELASTICSEARCH_INSECURE environment variable not being set.
@taylor-swanson taylor-swanson added the bug Something isn't working label Oct 13, 2023
@taylor-swanson taylor-swanson self-assigned this Oct 13, 2023
@taylor-swanson taylor-swanson marked this pull request as ready for review October 13, 2023 20:43
tobio
tobio previously approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/clients/config/elasticsearch.go

if insecure, ok := os.LookupEnv("ELASTICSEARCH_INSECURE"); ok {
if insecureValue, err := strconv.ParseBool(insecure); err != nil {
if insecureValue, err := strconv.ParseBool(insecure); err == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@taylor-swanson taylor-swanson mentioned this pull request Oct 17, 2023
Merged
tobio
tobio previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylor-swanson
Copy link
Contributor Author

@tobio, looks like the merge cleared your review, so if you could re-approve and merge, that'd be great!

@taylor-swanson taylor-swanson mentioned this pull request Oct 26, 2023
Merged
@tobio tobio merged commit 8afba4d into elastic:main Oct 26, 2023
@taylor-swanson taylor-swanson deleted the bug/fleet-agent-policy-monitoring branch October 27, 2023 13:08
@taylor-swanson taylor-swanson mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Updating Existing Fleet Policy to Remove Agent Logging Fails
2 participants
@taylor-swanson @tobio