[Kibana SLO] Add tags support
#495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
force-pushed
the
kibana-slo/add-tags-support
branch
from
fd7de03 to
e509e5d
Compare
afharo
force-pushed
the
kibana-slo/add-tags-support
branch
from
b4821b8 to
b6c9c3c
Compare
afharo
commented
Nov 30, 2023
Comment on lines
+479
to
+480
| Good: d.Get(indicatorType + ".0.good").(string), | ||
| Total: d.Get(indicatorType + ".0.total").(string), |
| Type: indicatorAddressToType[indicatorType], | ||
| Params: slo.IndicatorPropertiesCustomMetricParams{ | ||
| Filter: d.Get(indicatorType + ".0.filter").(string), | ||
| Filter: getOrNilString(indicatorType+".0.filter", d), |
| resource.TestCheckResourceAttr("elasticstack_kibana_slo.test_slo", "settings.0.sync_delay", "1m"), | ||
| resource.TestCheckResourceAttr("elasticstack_kibana_slo.test_slo", "settings.0.frequency", "1m"), | ||
| resource.TestCheckResourceAttr("elasticstack_kibana_slo.test_slo", "space_id", "default"), | ||
| resource.TestCheckResourceAttr("elasticstack_kibana_slo.test_slo", "group_by", "some.field"), |
There was a problem hiding this comment.
group_by is not compatible with 8.9.0, but it didn't fail before because our CreateSlo method didn't include it in the request (added here)
Co-authored-by: Toby Brain <tobio85@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLO client updated from OAS + adding tags support