Skip to content

Updating role mapping name field to update or delete role mappings wh… #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2023
Merged

Updating role mapping name field to update or delete role mappings wh… #503

merged 2 commits into from
Dec 6, 2023

Conversation

SquareShark
Copy link
Contributor

@SquareShark SquareShark commented Dec 6, 2023 •
edited
Loading

#501

  • Update the name field for the role_mappings.go to "ForceNew", I was seeing the issue where if you update the name for a role mapping it would create a new role mapping but not actually remove the one it was replacing. Role.go has this feature in already so figured this was just missed out and wanted to add it in.

@SquareShark SquareShark marked this pull request as ready for review December 6, 2023 21:08
@SquareShark SquareShark mentioned this pull request Dec 6, 2023
Closed
tobio
tobio approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing this one up.

@tobio tobio merged commit 7ed5ede into elastic:main Dec 6, 2023
tobio added a commit that referenced this pull request Dec 12, 2023
@tobio
Merge remote-tracking branch 'origin/main' into data-views
8a936d2 
* origin/main:
  Updating role mapping name field to update or delete role mappings wh… (#503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SquareShark @tobio