Skip to content

Conversation

shulkaolka
Copy link
Contributor

No description provided.

Update unittest UpsertRowByPrimaryKeyMSSQLSpec
1. Oracle DB don't understand timestamp type (bug from ojdbc driver v6)
2. Required fields are not shown as required (no "*") for DBs: mySQL, postgreSQL, Oracle
1. Oracle DB don't understand timestamp type (bug from ojdbc driver v6)
2. Required fields are not shown as required (no "*") for DBs: mySQL, postgreSQL, Oracle
 from gitignore
README.md Outdated
Before you can deploy any code into elastic.io **you must be a registered elastic.io platform user**. Please see our home page at [http://www.elastic.io](http://www.elastic.io) to learn how.
#### Environment variables
For unit-testing
For unit-testing is needed specify following environment variables:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For unit-testing is needed to specify following environment variables

README.md Outdated
As an input metadata you will get a Primary Key field to provide the data inside as a clause value.

## Current limitations
1. Only tables with one [PRIMARY KEY](https://en.wikipedia.org/wiki/Primary_key "PRIMARY KEY") is supported. Message ``Table has not Primary Key. Should be one Primary Key

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tables with one PRIMARY KEY is supported.
You will see the message Table has not Primary Key. Should be one Primary Key, if the selected table doesn't have a primary key. Also, you will see the message Composite Primary Key is not supported, if the selected table has composite primary key.

README.md Outdated
1. Only tables with one [PRIMARY KEY](https://en.wikipedia.org/wiki/Primary_key "PRIMARY KEY") is supported. Message ``Table has not Primary Key. Should be one Primary Key
`` should be displayed if the table without any primary key will be selected and message ``Composite Primary Key is not supported
`` should be displayed if the table with composite primary key will be selected.
2. Only following versions of DataBase are supported:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only following versions of database types are supported:

README.md Outdated
- ``PostgreSQL`` - compatible with PostgreSQL 8.2 and higher
- ``Oracle`` - compatible with Oracle Database 8.1.7 - 12.1.0.2
- ``MSSQL`` - compatible with Microsoft SQL Server 2008 R2 and higher
3. For Action "Upsert by primary key" metadata analysis ignores nullable/non-nullable fields, it will be throw SQL Server exception ``Cannot insert the value NULL into...`` if non-nullable fields don't fill for Insert operation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation of the action Upsert By Primary Key doesn't mark non-nullable fields as required fields at a dynamic metadata. In case of updating such fields with an empty value you will get SQL Exception Cannot insert the value NULL into.... You should manually fill in all non-nullable fields with previous data, if you want to update part of columns in a row, even if data in that fields doesn't change.

@shulkaolka shulkaolka merged commit 2bda8cd into v2 Sep 14, 2018
@shulkaolka shulkaolka deleted the upsert branch September 14, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants