Split URI to user-friendly configuration parameters #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubairov
reviewed
Jun 14, 2018
lib/actions/select.js
Outdated
| function init(cfg) { | ||
| const conString = cfg.uri; | ||
| const conString = 'mssql://' | ||
| + cfg.username |
There was a problem hiding this comment.
Username can't contain ':' right?
There was a problem hiding this comment.
The issue was fixed in the last commit by escaping special characters in username
lib/actions/select.js
Outdated
| const conString = 'mssql://' | ||
| + cfg.username | ||
| + ':' | ||
| + cfg.password |
There was a problem hiding this comment.
same here, no ':' and '@' allowed right?
There was a problem hiding this comment.
The issue was fixed in the last commit by escaping special characters in password
| "request-promise": "^4.1.1" | ||
| "elasticio-node": "0.0.9", | ||
| "elasticio-sailor-nodejs": "^2.2.1", | ||
| "mssql": "^4.1.0", |
…username and password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently one have to enter an MSSQL URI as a string like:
mssql://username:password@localhost/database
Issues with it:
Not very user friendly
Password is visible in UI and not protected
However, advantages are that many possible settings could be build in as encoded in URI. We need t good solution to combine streights but not weaknesses.
Issue: https://github.com/elasticio/mssql-component/issues/6