Add UpdateIndexSettingsRequest #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you write unit and sandbox tests for this ? Plz :-) |
| */ | ||
| public function getSupportedClass() | ||
| { | ||
| return IndexResponse::class; |
There was a problem hiding this comment.
@SHyx0rmZ This is a PHP 5.5 only feature. Please use a PHP 5.4 compatible version of returning a class name.
|
@SHyx0rmZ Please check your PR for any features requiring PHP 5.5 or later. I've marked one of the usages of |
|
I'm sorry, I already noticed but haven't come around to fixing it, yet. Will do so shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.