add mapping

elbwalker · Jun 6, 2024 · 3b6cabd · 3b6cabd
1 parent 9f93511
commit 3b6cabd
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 6 deletions.
diff --git a/packages/clients/walkerjs/src/__tests__/destination.test.ts b/packages/clients/walkerjs/src/__tests__/destination.test.ts
@@ -660,21 +660,47 @@ describe('Destination', () => {
     elb('walker destination', {
       push: mockPush,
       pushBatch: mockBatch,
-      config: { mapping: { '*': { visible: { batch: 2000 } } } },
+      config: {
+        mapping: {
+          '*': {
+            visible: { batch: 2000 },
+            click: { batch: 2000 },
+            important: {},
+          },
+        },
+      },
     });
     elb('walker run');
 
     elb('foo visible');
     elb('bar visible');
+    elb('foo click');
+    elb('foo important');
 
+    expect(mockPush).toHaveBeenCalledTimes(1); // Push important immediately
     expect(mockBatch).toHaveBeenCalledTimes(0);
     jest.runAllTimers();
-    expect(mockBatch).toHaveBeenCalledTimes(1);
+    expect(mockBatch).toHaveBeenCalledTimes(2);
     expect(mockBatch).toHaveBeenNthCalledWith(
       1,
       [
-        { event: expect.objectContaining({ event: 'foo visible' }) },
-        { event: expect.objectContaining({ event: 'bar visible' }) },
+        {
+          event: expect.objectContaining({
+            event: 'foo visible',
+          }),
+          mapping: expect.objectContaining({ batch: 2000 }),
+        },
+        {
+          event: expect.objectContaining({
+            event: 'bar visible',
+          }),
+          mapping: expect.objectContaining({ batch: 2000 }),
+        },
+        expect.objectContaining({
+          event: expect.objectContaining({
+            event: 'foo click',
+          }),
+        }),
       ],
       expect.anything(),
       expect.anything(),

diff --git a/packages/clients/walkerjs/src/lib/push.ts b/packages/clients/walkerjs/src/lib/push.ts
@@ -163,7 +163,7 @@ export function pushToDestination(
     const batch = mappingEvent?.batch;
     if (batch && destination.pushBatch) {
       destination.batch = destination.batch || [];
-      destination.batch.push({ event }); // @TODO , mapping: mappingEvent });
+      destination.batch.push({ event, mapping: mappingEvent });
 
       mappingEvent.batchFn =
         mappingEvent.batchFn ||

diff --git a/packages/types/src/destination.ts b/packages/types/src/destination.ts
@@ -28,7 +28,7 @@ export interface Mapping<EventCustom> {
 
 export type Batch<EventCustom> = Array<{
   event: WalkerOS.Event;
-  mapping?: EventCustom;
+  mapping?: EventConfig<EventCustom>;
 }>;
 
 export type Meta = {